Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pymupdf #25906

Merged
merged 40 commits into from
Mar 29, 2024
Merged

Add pymupdf #25906

merged 40 commits into from
Mar 29, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Mar 28, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymupdf) and found some lint.

Here's what I've got...

For recipes/pymupdf:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymupdf) and found some lint.

Here's what I've got...

For recipes/pymupdf:

  • The home item is expected in the about section.

For recipes/pymupdf:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymupdf) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

import: 'fitz'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/pymupdf_1711681974489/test_tmp/run_test.py", line 2, in <module>
    import fitz
  File "/home/conda/staged-recipes/build_artifacts/pymupdf_1711681974489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.11/site-packages/fitz/__init__.py", line 22, in <module>
    from fitz.fitz import *
  File "/home/conda/staged-recipes/build_artifacts/pymupdf_1711681974489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.11/site-packages/fitz/fitz.py", line 14, in <module>
    from . import _fitz
ImportError: /home/conda/staged-recipes/build_artifacts/pymupdf_1711681974489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.11/site-packages/fitz/_fitz.cpython-311-x86_64-linux-gnu.so: undefined symbol: gumbo_destroy_output

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymupdf) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pymupdf:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymupdf) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes, ready for review

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@jan-janssen
Copy link
Member Author

@conda-forge/help-python-c

@jan-janssen
Copy link
Member Author

Once conda-forge/mupdf-feedstock#37 is merged pymupdf can also be upgraded to the latest version 1.24.0.

@chrisburr chrisburr merged commit c43971f into conda-forge:main Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants