Adds pyrtools

[billbrod]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

plenoptic depends on pyrtools, and I'm the maintainer of both. They are used in visual neuroscience for building and understanding computational models of neurons and/or perception.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plenoptic, recipes/pyrtools) and found some lint.

Here's what I've got...

For recipes/plenoptic:

• The home item is expected in the about section.

For recipes/pyrtools:

• The home item is expected in the about section.
• Non noarch packages should have python requirement without any version constraints.
• Non noarch packages should have python requirement without any version constraints.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plenoptic, recipes/pyrtools) and found some lint.

Here's what I've got...

For recipes/pyrtools:

• Non noarch packages should have python requirement without any version constraints.
• Non noarch packages should have python requirement without any version constraints.

[billbrod]

@conda-forge-admin, please ping conda-forge/help-python

Hi conda forge! I'm trying to get this ready for review, but I don't understand the lint error I'm getting for pyrtools -- should I remove the python >= 3.7 version constraint under requirements:host and requirements:run (I'm assuming that's why the error shows up twice). But my package does require a minimum python version of 3.7 -- is there another way to indicate thta?

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

[billbrod]

And I'm not sure if the version constraint issue is related to or independent of the failing OSX and Windows builds -- building succeeds for me on github actions (e.g., ) when I build wheels for pip. I'm not familiar enough with what conda is doing to understand why it would fail here. I'd appreciate any help figuring this out!

[billbrod]

The Windows build is failing and I think it's because I require pytorch, the windows build for which is hosted on the pytorch channel. Looking at this other PR, it looks like it's okay that the Windows build fails and that I shouldn't specify the pytorch channel here? (And then my installation instructions should tell people to try adding that channel if the installation fails?)

[BastianZim]

Yes, you can just ignore the failure.
You can inform your users but conda/mamba will tell someone when installing, that the package could not be found on the specific channel. If they then go to the pytorch website, they will find the necessary instructions.
Just as a note: we don't recommend installing from multiple channels because there can be differences in compilation etc that can cause unexpected issues.

[billbrod]

Okay, that makes sense. What are my next steps then? Is there some way to fix the failing OSX build or should I ignore that as well?

And if you don't recommend installing from multiple channels, what do you recommend doing for pytorch?

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plenoptic, recipes/pyrtools) and found some lint.

Here's what I've got...

For recipes/pyrtools:

• Non noarch packages should have python requirement without any version constraints.
• Non noarch packages should have python requirement without any version constraints.

For recipes/pyrtools:

• This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/plenoptic, recipes/pyrtools) and found it was in an excellent condition.

[billbrod]

@conda-forge/staged-recipes I believe this is ready to be merged: I have fixed all the linters issues and my OSX and Linux builds are succeeding. The Windows build is still failing, because it requires conda-forge/pytorch-cpu-feedstock#32, so will not succeed for now.

Let me know if there are any other changes I need to make!

[github-actions]

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

[billbrod]

@conda-forge/help-python is the proper team to notify, I believe.

[xhochy]

Can you please separate these packages? As only one is noarch I'm hesitant to merge with failing Windows CI.

[billbrod]

Okay. Since plenoptic (which also relies on pytorch and thus has the failing windows build) depends on pyrtools, is the way to do this to remove plenoptic from this PR, merge pyrtools, and then open a new PR with plenoptic?

[xhochy]

Yes!

[billbrod]

Alright, I went ahead and removed plenoptic!

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrtools/meta.yaml) and found it was in an excellent condition.