Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentencepiece 0.1.99 #40

Merged
merged 3 commits into from
Jun 6, 2023
Merged

sentencepiece 0.1.99 #40

merged 3 commits into from
Jun 6, 2023

Conversation

h-vetinari
Copy link
Member

No idea why the bot keeps failing to open PRs here... 😑

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping up the version!

Can't say I understand the each line in this PR... As long as CI goes through, I'm good with merging this.

@h-vetinari
Copy link
Member Author

h-vetinari commented Jun 6, 2023

Thanks! CI already passed for the previous commit, I just changed the url-scheme to something the bot should hopefully discover more easily now.

The diff hardly makes any sense without reading the patches. I also finally opened an upstream issue to discuss how we may upstream some of these (especially the abseil-related ones), which explains most of the context around them.

@h-vetinari h-vetinari merged commit af37334 into conda-forge:main Jun 6, 2023
0 of 13 checks passed
@h-vetinari h-vetinari deleted the bump branch June 6, 2023 07:13
@setu4993
Copy link
Contributor

setu4993 commented Jun 6, 2023

Thank you for opening the issue upstream, @h-vetinari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants