-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing r41 issue #12
Fixing r41 issue #12
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.23.15.09.04
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.23.15.09.04
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is not that a jpeg
dependency is needed here - noarch
R packages never need shared libraries in host
. Rather r-jpeg
exclusively used jpeg
to supply libjpeg for all of its linux-64 R 4.1 builds on Conda Forge. When Conda Forge changed to libjpeg-turbo
to supply libjpeg, it was only building R 4.2 and 4.3 for linux-64. Hence, there are no linux-64 R 4.1 builds of r-jpeg
that work with the libjpeg-turbo
library.
The error encountered is because some of the old r-jpeg
builds didn't properly declare their dependencies in the metadata. See conda-forge/r-jpeg-feedstock#13.
The solution is to get a newer linux-64 R 4.1 r-jpeg
build made.
However, the motivation here is not explicated. It has been pointed out previously that providing extended older R version support is not generally sustainable. Conda Forge currently builds for R 4.2 and 4.3, which some partial support for Windows where we can only build R 4.1. Outside of these, it is important to communicate why there is a need to use Conda Forge resources to generate out-of-cycle builds.
The motivation for extended support of R older versions is to provide reproducibility in R3.6, which is the older version supported. Migration to R>=4.0 it's on going but support for R3.6 it's still requested, and no decision has been yet made on which version of R>=4.0 will be become the reference for future releases. This package ( I have just made a patch to support R4.1, but just to be considering that R4.1 it's been supported for the rest of packages. From your comment, it's clear that for future releases/builds, R4.1 should be considered to be removed. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)