Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix version num of conda package #69

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fix version num of conda package #69

merged 2 commits into from
Jun 7, 2022

Conversation

jenshnielsen
Copy link
Contributor

Trying to fix microsoft/Qcodes#4234

@conda-forge-linter

This comment was marked as outdated.

Sign in to view
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

astafan8
astafan8 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be a weird error with conda builds, right? because on pypi everything is correct

@jenshnielsen
Copy link
Contributor Author

@astafan8 Yes, I think what happens is that conda downloads the sdist and then conda calling pip overwrites the PKG-INFO file (which already contained the right version info)

@jenshnielsen
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-linter

This comment was marked as outdated.

Sign in to view
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jenshnielsen
Copy link
Contributor Author

output from pip config list

source tree in: /home/conda/feedstock_root/build_artifacts/qcodes_1654613283818/work
export PREFIX=/home/conda/feedstock_root/build_artifacts/qcodes_1654613283818/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac
export BUILD_PREFIX=/home/conda/feedstock_root/build_artifacts/qcodes_1654613283818/_build_env
export SRC_DIR=/home/conda/feedstock_root/build_artifacts/qcodes_1654613283818/work
:env:.cache-dir='/home/conda/feedstock_root/build_artifacts/qcodes_1654613283818/pip_cache'
:env:.ignore-installed='True'
:env:.no-build-isolation='False'
:env:.no-dependencies='True'
:env:.no-index='True'

conda-forge-webservices[bot] and others added 2 commits June 7, 2022 21:17
@jenshnielsen
MNT: Re-rendered with conda-build 3.21.9, conda-smithy 3.20.0, and co…
f54b839 
…nda-forge-pinning 2022.06.06.01.05.55
@jenshnielsen
Add host dependency on versioningit.
7f65305 
Conda does not seem to honor build time dependencies
from pyproject.toml this is similar to what is suggested for
setuptools_scm
https://conda-forge.org/docs/maintainer/knowledge_base.html#using-setuptools-scm
@jenshnielsen
Copy link
Contributor Author

adding versioningit as a host dependency as suggested here for setuptools_scm https://conda-forge.org/docs/maintainer/knowledge_base.html seems to resolve the issue

@jenshnielsen jenshnielsen changed the title [WIP] Fix version number fix version num of conda package Jun 7, 2022
@jenshnielsen jenshnielsen added the automerge Merge the PR when CI passes label Jun 7, 2022
@jenshnielsen jenshnielsen merged commit ed1b0e8 into conda-forge:main Jun 7, 2022
@jenshnielsen jenshnielsen deleted the fix_version_info branch June 7, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

@Dominik-Vogel Dominik-Vogel Awaiting requested review from Dominik-Vogel

@basnijholt basnijholt Awaiting requested review from basnijholt basnijholt is a code owner

@samantha-ho samantha-ho Awaiting requested review from samantha-ho samantha-ho is a code owner

@sohailc sohailc Awaiting requested review from sohailc

@trevormorgan trevormorgan Awaiting requested review from trevormorgan trevormorgan is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshnielsen @conda-forge-linter @astafan8