-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 0.6.2, defer pytorch variant selection to user #9
Conversation
…da-forge-pinning 2019.04.25
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
…da-forge-pinning 2019.04.25
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
(well, the tests worked locally except for the ones that needed the spacy |
…da-forge-pinning 2019.04.25
Tried replacing It seems like knowing how to installl CPU/GPU variants is a A Thing with torch, so expecting a user to have to say: conda install -c conda-forge -c <somebody> pytorch-<whatever> pytorch-pretrained-bert-feedstock is not entirely unreasonable, if somewhat unpleasant... |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Needed (maybe) for conda-forge/allennlp-feedstock#5
Adds tests. The tests download big models. They should probably be managed as additionalThere is no good way (a la spacy) to cache the downloaded models at present. Really a bummer, they are quite large. Tests did pass locally on linux, though 😝source
s andoutputs
.