Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #181

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Jun 1, 2023

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5149640915, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam ngam closed this Jun 6, 2023
@ngam ngam reopened this Jun 6, 2023
@ngam
Copy link
Contributor

ngam commented Jun 6, 2023

@hawkinsp @jakevdp I am working towards making jaxlib compatible with the newly release cuda 12 packages in conda-forge. Won't merge for a few days, but suggestions and thoughts are welcome :)

@ngam
Copy link
Contributor

ngam commented Jun 6, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jaxlib-feedstock/actions/runs/5193531178.

@ngam
Copy link
Contributor

ngam commented Jun 6, 2023

Need to modify the custom bazel toolchain likely...

@carterbox
Copy link
Member

carterbox commented Jun 7, 2023

Here's the merged migration PR for libmagma. Highlights include:

  • The cudatoolkit package / CUDA_HOME doesn't exist anymore. You need to explicitly add cuda libraries to the host requirements and guard them with jinja, so they are only added for cuda 12.
  • There is an unpatched bug with the nvcc conda package such that it only searches $BUILD_PREFIX for cuda headers and libraries and doesn't search $PREFIX. Not sure when the fix will be published, but if you're using CMAKE you can add include and link paths to the CUDA_FLAGS environment variable A patch has been merged, so nvcc should find libs and headers in the host prefix

@ngam
Copy link
Contributor

ngam commented Jun 8, 2023

The larger problem here may lie in the fact that we use a custom bazel toolchain. I will investigate when I get a chance soon.

@ngam ngam marked this pull request as draft June 10, 2023 05:41
@jakirkham jakirkham added the bot-rerun Instruct the bot to retry the PR label Aug 24, 2023
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/5960972966

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_hc632db branch August 24, 2023 07:54
@jakirkham
Copy link
Member

The bot opened a new PR: #189

@ngam
Copy link
Contributor

ngam commented Aug 24, 2023

Thanks @jakirkham! Will try to take care of this soon 😄

@hawkinsp
Copy link
Contributor

Sorry I missed the earlier ping in this thread. I don't think anything particularly special is needed for CUDA 12 builds: the only thing that I note is that CUDA 12 dropped support for Kepler (sm 35) GPUs. Otherwise few changes should be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants