Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faiss v1.8.0 #75

Merged
merged 34 commits into from
Aug 8, 2024
Merged

faiss v1.8.0 #75

merged 34 commits into from
Aug 8, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented May 15, 2024 •
edited
Loading

First chunk in a long list of things to do here...

Closes #62
Closes #70
Closes #71
Closes #72
Closes #74

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jan-janssen jan-janssen mentioned this pull request Jun 8, 2024
Closed
10 tasks
This was referenced Jul 15, 2024
Merged
Closed
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@regro-cf-autotick-bot @h-vetinari
Rebuild for python312
fd79554
@regro-cf-autotick-bot @h-vetinari
Rebuild for CUDA 12 w/arch + Windows support
89d9b74 
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@h-vetinari
drop avx2 library
5854eb1 
this can come back later as a proper archspec build
@h-vetinari
Copy link
Member Author

@conda-forge/cuda, I'm getting the following error on linux-aarch64 with CUDA 12.0, despite being on the alma 8 image which should have a new enough glibc (here are the logs from before the last force-push)

  File "$PREFIX/lib/python3.11/site-packages/faiss/swigfaiss.py", line 10, in <module>
    from . import _swigfaiss
ImportError: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by $PREFIX/lib/python3.11/site-packages/faiss/../../../libfaiss.so)

Any ideas what's causing this or how to fix it?

It's also curious that the higher glibc-requirement is apparently specific to linux-aarch64; it doesn't show up on linux-64 or linux-ppc64le.

CC @beckermr @isuruf @jakirkham in case the alma docker images are still missing missing something related to cross-compilation/QEMU somehow?

@isuruf
Copy link
Member

isuruf commented Aug 8, 2024

You need to fix the line https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/94113f23f45b667a5521a37d06af82da883c14df/recipe/cross_compile_support.sh#L23 to use the correct 2.28 version.

@h-vetinari h-vetinari mentioned this pull request Aug 8, 2024
Merged
@h-vetinari h-vetinari changed the title faiss 1.8.0 faiss v1.8.0 Aug 8, 2024
@h-vetinari
Copy link
Member Author

Alright, let's revive this 🧟 feedstock 🪄

@h-vetinari h-vetinari merged commit 2a2ebfc into conda-forge:main Aug 8, 2024
12 of 16 checks passed
@h-vetinari h-vetinari deleted the 1.8 branch August 8, 2024 22:54
@h-vetinari h-vetinari mentioned this pull request Aug 9, 2024
Merged
17 tasks
@jakirkham jakirkham mentioned this pull request Aug 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-vetinari @isuruf @glemaitre @regro-cf-autotick-bot