Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrecting the feedstock / Bump to 1.3.0 #12

Merged
merged 20 commits into from
Jan 16, 2021
Merged

Resurrecting the feedstock / Bump to 1.3.0 #12

merged 20 commits into from
Jan 16, 2021

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jan 13, 2021 •
edited
Loading

Continuing #10 from @jasonge27, and updating some things along the way.

Closes #1
Closes #3
Closes #4
Closes #5
Closes #9
Closes #10

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Jan 13, 2021
Closed
5 tasks
@h-vetinari
Update import tests
d1124a0 
See how allnnlp-{models,semparse,server} was split into separate packages
Among many PRs, see e.g. allenai/allennlp #2332, #3700, #3853, #3939, #3941
@h-vetinari
Copy link
Member Author

@conda-forge/allennlp @jasonge27

This is green and ready. :)

Given that the feedstock hasn't been updated in >2 years, I'm taking the liberty of adding myself to the feedstock maintainers, so that I can hopefully continue helping to shepherd this into the future. 🙃

@h-vetinari h-vetinari changed the title Bump to 1.3.0 Resurrecting the feedstock / Bump to 1.3.0 Jan 13, 2021
@h-vetinari h-vetinari mentioned this pull request Jan 13, 2021
Open
@h-vetinari
Copy link
Member Author

h-vetinari commented Jan 13, 2021 •
edited
Loading

OK, reverting the osx & win builds again, those are blocked on conda-forge/sentencepiece-feedstock#12 & conda-forge/pytorch-cpu-feedstock#32, conda-forge/jsonnet-feedstock#24, respectively.

@h-vetinari h-vetinari mentioned this pull request Jan 13, 2021
Open
@h-vetinari
Copy link
Member Author

@conda-forge/core
The maintainers here are not responding (and the feedstock had no meaningful updates for >2 years) - could someone please merge this? I'm willing to step up as maintainer.

@CurtLH CurtLH merged commit 5c61272 into conda-forge:master Jan 16, 2021
@h-vetinari
Copy link
Member Author

Thanks @CurtLH! :)

@h-vetinari h-vetinari deleted the v1.x branch January 16, 2021 17:42
@h-vetinari h-vetinari mentioned this pull request Jan 17, 2021
Merged
@h-vetinari h-vetinari mentioned this pull request Jan 30, 2021
Open
@h-vetinari h-vetinari mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda package allennlp=0.9.0
4 participants
@h-vetinari @conda-forge-linter @CurtLH @jasonge27