-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PcapPlusPlus: add version 24.09 #25348
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
compiler_version = Version(self.settings.compiler.version) | ||
if self.settings.compiler == "gcc" and compiler_version < "5.1": | ||
raise ConanInvalidConfiguration("PcapPlusPlus requires GCC >= 5.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because the build with GCC 5.0 fails:
https://c3i.jfrog.io/c3i/misc/logs/pr/25348/1-linux-gcc-legacy/pcapplusplus/24.09//67b8b30a48b5f4d20d090acd959766840b9443a5-build.txt
https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/25348/1-linux-gcc-legacy/pcapplusplus/24.09//summary.json
I'm not sure why initializing an std::array
with an initialization list doesn't work, but this thread suggests it might be related to a bug in old GCC versions
This is new code that was added in v24.09 I can add this validation only for v24.09, but I figured that GCC 5 is pretty old so this validation can apply to v23.09 as well. Please let me know what you think
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
@AbrilRBS can you please take a look at this PR? |
Summary
Changes to recipe: pcapplusplus/24.09
Motivation
This is a new version of PcapPlusPlus, released a year after the previous version. It contains a lot of updates and changes
Details
High level summary of the changes: https://github.com/seladb/PcapPlusPlus/releases/tag/v24.09
Full Changelog:
v23.09...v24.09