Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire-hpp: add version 1.0 #25317

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fire-hpp: add version 1.0 #25317

merged 2 commits into from
Sep 25, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 19, 2024

Summary

Changes to recipe: fire-hpp/1.0

Motivation

This is the first stable release.

Details

kongaskristjan/fire-hpp@v0.2...v1.0


@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Sep 19, 2024
@conan-center-bot

This comment has been minimized.

@@ -1,4 +1,7 @@
sources:
"1.0":
url: "https://github.com/kongaskristjan/fire-hpp/archive/v0.2.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @toge, the URL is from the previous version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErniGH
Sorry, I fixed.

@ErniGH ErniGH self-assigned this Sep 19, 2024
@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Sep 19, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (0df6f3556b659dc15960dcadcb952497061674f7):

  • fire-hpp/1.0:
    Built 5 packages out of 11 (All logs)

  • fire-hpp/0.2:
    Built 5 packages out of 11 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toge!

I see in https://github.com/kongaskristjan/fire-hpp/blob/master/docs/conan.md that upstream expects users to use their own conanfile. Maybe we could opena. PR to also mention the usual conan install --requires=fire-hpp/1.0 approach, what do you think? Are you up for it? :)

@conan-center-bot conan-center-bot merged commit f274df8 into conan-io:master Sep 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants