Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geos: add version 3.12.0 #18845

Merged
merged 9 commits into from
Sep 11, 2023
Merged

geos: add version 3.12.0 #18845

merged 9 commits into from
Sep 11, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Jul 23, 2023

Specify library name and version: geos/3.12.0

geos/3.12.0 requires C++14.

@prince-chrismc prince-chrismc mentioned this pull request Jul 23, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 23, 2023
Open
Open
@ericLemanissier ericLemanissier mentioned this pull request Jul 24, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@aliaksei135 aliaksei135 mentioned this pull request Jul 24, 2023
Open
This was referenced Jul 24, 2023
Closed
Closed
@ghost
Copy link

ghost commented Jul 24, 2023

I detected other pull requests that are modifying geos/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@aliaksei135
Copy link

This fixes #18878 when merged

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@aliaksei135
Copy link

Looks like this might have been fixed on the upstream repo: libgeos/geos#945

@uilianries uilianries self-assigned this Sep 7, 2023
@uilianries
Fix Windows build by passing build type
f153e4e 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a change to pass build type as cached variable as that option is cached in 3.12. Testing locally it worked.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (f153e4ea7bb24fa1874768205626557060385bf7):

  • geos/3.11.1:
    All packages built successfully! (All logs)

  • geos/3.11.2:
    All packages built successfully! (All logs)

  • geos/3.10.2:
    All packages built successfully! (All logs)

  • geos/3.11.0:
    All packages built successfully! (All logs)

  • geos/3.10.3:
    All packages built successfully! (All logs)

  • geos/3.12.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (f153e4ea7bb24fa1874768205626557060385bf7):

  • geos/3.11.2:
    All packages built successfully! (All logs)

  • geos/3.11.0:
    All packages built successfully! (All logs)

  • geos/3.11.1:
    All packages built successfully! (All logs)

  • geos/3.10.2:
    All packages built successfully! (All logs)

  • geos/3.10.3:
    All packages built successfully! (All logs)

  • geos/3.12.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d6c62a4 into conan-io:master Sep 11, 2023
38 checks passed
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@toge @uilianries @ericLemanissier
(conan-io#18845) geos: add version 3.12.0
6a44a2d 
* geos: add version 3.12.0

* 3.12.0 requires C++14

* add patch to solve compilation error on msvc

* fix patch_type

* Fix Windows build by passing build type

Signed-off-by: Uilian Ries <uilianries@gmail.com>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @aliaksei135 @SSE4 @uilianries @jwillikers