-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlpp11] Support Conan v2 and add version 0.62 #17993
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I detected other pull requests that are modifying sqlpp11/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Also closes #17857 (not sure if it must be added to the main description for it to auto close once done) |
This comment has been minimized.
This comment has been minimized.
One can probably pull in the v1 test from #17754 |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
…ex into sqlpp11/0.62
No problem, I just updated the PR description to close that issue when merging it.
Yes, that template we created long time ago, but no longer listed in https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only/all
Good catch, fixed! |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
@uilianries |
@CJCombrink An internal error occurred in the CI. I just restarted the PR now. Thank you for pinging! |
This comment has been minimized.
This comment has been minimized.
@CJCombrink The CI is overloaded as we trying to generate new packages internally. No problem, this PR is marked as |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question regarding msvc min version, othewise looks great :)
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@uilianries, would you be willing to approve this PR so that I may gain access and speed up the merge of this PR and others in future? |
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 9 ( |
@LvdStokker @CJCombrink The pull request has been merged and the package should be available now in Conan Center. Regards! |
Thanks @uilianries |
Thanks a lot @uilianries. Much appreciated. It may still be uploading to Artifactory, I am not certain but I will look out on https://conan.io/center/sqlpp11 |
@CJCombrink Github permission I guess. I just closed them now, thank you for pinging. |
All right! Thank you for the hint, I'll remember next time!
…On Wed, Jun 28, 2023 at 7:25 PM Chris Mc ***@***.***> wrote:
@uilianries <https://github.com/uilianries> you made a tiny mistake
linking issues to close
You need to write close once for each github issue you want to link :)
—
Reply to this email directly, view it on GitHub
<#17993 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFFAHJHBGHOMTKHHQ2KEU3XNRSHXANCNFSM6AAAAAAZOL2DTE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Cordialmente,
Uilian Ries
***@***.***>
|
* Update sqlpp11 to 0.62 Signed-off-by: Uilian Ries <uilianries@gmail.com> * add test_v1_package Signed-off-by: Uilian Ries <uilianries@gmail.com> * remove comment Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix config.yml Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix target name Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update recipes/sqlpp11/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
* Update sqlpp11 to 0.62 Signed-off-by: Uilian Ries <uilianries@gmail.com> * add test_v1_package Signed-off-by: Uilian Ries <uilianries@gmail.com> * remove comment Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix config.yml Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix target name Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update recipes/sqlpp11/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
from conan.tools.build import check_min_cppstd | ||
from conan.tools.layout import basic_layout | ||
from conan.tools.files import get, copy | ||
from conan import Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this import is illegal and breaks in conan 2.0.10
Specify library name and version: sqlpp11/0.62
closes #17992 #17857 #17754
/cc @LvdStokker @CJCombrink