Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlpp11] Support Conan v2 and add version 0.62 #17993

Merged
merged 10 commits into from
Jun 27, 2023

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Jun 21, 2023

Specify library name and version: sqlpp11/0.62

  • Remove 0.5x versions
  • Add 0.62 version
  • Add support to be built with Conan 2.x
  • Update test_package to run with Conan 2.x
  • Added add test_v1_package

closes #17992 #17857 #17754

/cc @LvdStokker @CJCombrink


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ghost
Copy link

ghost commented Jun 21, 2023

I detected other pull requests that are modifying sqlpp11/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@CJCombrink
Copy link
Contributor

CJCombrink commented Jun 21, 2023

Also closes #17857 (not sure if it must be added to the main description for it to auto close once done)

@conan-center-bot

This comment has been minimized.

@CJCombrink
Copy link
Contributor

@uilianries

Didn't add test_v1_package

One can probably pull in the v1 test from #17754

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@CJCombrink

Also closes #17857 (not sure if it must be added to the main description for it to auto close once done)

No problem, I just updated the PR description to close that issue when merging it.

One can probably pull in the v1 test from #17754

Yes, that template we created long time ago, but no longer listed in https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only/all

I am guessing this must match recipes/sqlpp11/all/conandata.yml which states 0.62 only

Good catch, fixed!

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@CJCombrink
Copy link
Contributor

@uilianries
Any clues on what went wrong this time?

@uilianries
Copy link
Member Author

@CJCombrink An internal error occurred in the CI. I just restarted the PR now. Thank you for pinging!

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member Author

@CJCombrink The CI is overloaded as we trying to generate new packages internally. No problem, this PR is marked as Unexpected Error and will be built again automatically.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question regarding msvc min version, othewise looks great :)

recipes/sqlpp11/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@LvdStokker
Copy link

@uilianries, would you be willing to approve this PR so that I may gain access and speed up the merge of this PR and others in future?

#18021 (review)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (c29a0043f3a882a68f7f8ab2a6ce7cb71e0f3720):

  • sqlpp11/0.62@:
    All packages built successfully! (All logs)

  • sqlpp11/0.61@:
    All packages built successfully! (All logs)

  • sqlpp11/0.60@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 9 (c29a0043f3a882a68f7f8ab2a6ce7cb71e0f3720):

  • sqlpp11/0.62@:
    All packages built successfully! (All logs)

  • sqlpp11/0.61@:
    All packages built successfully! (All logs)

  • sqlpp11/0.60@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a066c41 into conan-io:master Jun 27, 2023
5 checks passed
@uilianries
Copy link
Member Author

@LvdStokker @CJCombrink The pull request has been merged and the package should be available now in Conan Center. Regards!

@CJCombrink
Copy link
Contributor

Thanks @uilianries
Any reason why the linked tickets and PRs did not auto close?

@LvdStokker
Copy link

Thanks a lot @uilianries. Much appreciated. It may still be uploading to Artifactory, I am not certain but I will look out on https://conan.io/center/sqlpp11

@uilianries
Copy link
Member Author

@CJCombrink Github permission I guess. I just closed them now, thank you for pinging.

@uilianries
Copy link
Member Author

uilianries commented Jun 29, 2023 via email

tannerbitz pushed a commit to tannerbitz/conan-center-index that referenced this pull request Jul 8, 2023
* Update sqlpp11 to 0.62

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* add test_v1_package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* remove comment

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* fix config.yml

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* fix target name

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/sqlpp11/all/conanfile.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* Update sqlpp11 to 0.62

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* add test_v1_package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* remove comment

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* fix config.yml

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* fix target name

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/sqlpp11/all/conanfile.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
from conan.tools.build import check_min_cppstd
from conan.tools.layout import basic_layout
from conan.tools.files import get, copy
from conan import Version
Copy link
Contributor

@SpaceIm SpaceIm Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import is illegal and breaks in conan 2.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] sqlpp11/0.62
8 participants