Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bshoshany-thread-pool: add version 3.5.0 #17708

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

bshoshany
Copy link
Contributor

Specify library name and version: bshoshany-thread-pool/3.5.0


@CLAassistant
Copy link

CLAassistant commented May 26, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@bshoshany
Copy link
Contributor Author

I'm not really sure why all the checks are failing. Also, it seems to be re-checking all the previous releases for some reason. Can someone please take a look at this?

@bshoshany
Copy link
Contributor Author

I did all the same things I did in previous PRs, but it's failing checks. I think it may be due to the fact that the header files have been moved to the include subfolder, but it does work locally on my system. Again, I would appreciate if someone who understand conan better than I do could take a look.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@bshoshany
Copy link
Contributor Author

bshoshany commented Jun 5, 2023

Thanks so much @uilianries! I think I understand what I did wrong now, conanfile.py is supposed to be used for all versions (since it's in the all folder) but my commit only worked for v3.5.0 due to the path change in this version. So with your change, the same file now works for all versions. Just writing this here to remind this to myself in case I make any similar changes in future versions.

Looks like all the checks are passing now except 2, and I cannot see the details for these 2 since it says "403 Forbidden" when I click on them. Any ideas?

@uilianries
Copy link
Member

Looks like all the checks are passing now except 2, and I cannot see the details for these 2 since it says "403 Forbidden" when I click on them. Any ideas?

@bshoshany An internal error occurred, it seems be a networking error. Your PR will be restarted automatically. After the build, a log should be available on bot comment.

@bshoshany
Copy link
Contributor Author

@uilianries great, thanks for your help.

@conan-center-bot

This comment has been minimized.

@bshoshany
Copy link
Contributor Author

I think I figured out the problem, the change you made still didn't fix compatibility with older releases where the .hpp files were not in the include subfolder, so now I added 2 separate lines to account for .hpp files either in the root folder or the include subfolder. If this can be done in 1 line, that would be more elegant, but I could not find a way to make conan.tools.files.copy() look for files recursively in all subfolders.

I checked and this now works locally for all previous versions, so hopefully all the CI checks will pass this time.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (97c81383391e840fd24fa3acac72673f3f332200):

  • bshoshany-thread-pool/3.4.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.2.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.3.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.1.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.0.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.5.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 4 (97c81383391e840fd24fa3acac72673f3f332200):

An unexpected error happened and has been reported. Help is on its way! 🏇

@uilianries
Copy link
Member

@bshoshany Thank you for checking those headers. The Conan v2 pipeline failed again due an internal error, Jenkins was not able to connect to a pod. I just restarted it now.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshoshany
Copy link
Contributor Author

Great, thank you so much for your help! :)

@conan-center-bot conan-center-bot merged commit 8ffc849 into conan-io:master Jun 7, 2023
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* bshoshany-thread-pool: add version 3.5.0

* Update recipes/bshoshany-thread-pool/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* bshoshany-thread-pool: compatibility w/ older releases

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants