-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bshoshany-thread-pool: add version 3.5.0 #17708
Conversation
This comment has been minimized.
This comment has been minimized.
I'm not really sure why all the checks are failing. Also, it seems to be re-checking all the previous releases for some reason. Can someone please take a look at this? |
I did all the same things I did in previous PRs, but it's failing checks. I think it may be due to the fact that the header files have been moved to the |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Thanks so much @uilianries! I think I understand what I did wrong now, Looks like all the checks are passing now except 2, and I cannot see the details for these 2 since it says "403 Forbidden" when I click on them. Any ideas? |
@bshoshany An internal error occurred, it seems be a networking error. Your PR will be restarted automatically. After the build, a log should be available on bot comment. |
@uilianries great, thanks for your help. |
This comment has been minimized.
This comment has been minimized.
I think I figured out the problem, the change you made still didn't fix compatibility with older releases where the I checked and this now works locally for all previous versions, so hopefully all the CI checks will pass this time. |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 ( An unexpected error happened and has been reported. Help is on its way! 🏇 |
@bshoshany Thank you for checking those headers. The Conan v2 pipeline failed again due an internal error, Jenkins was not able to connect to a pod. I just restarted it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great, thank you so much for your help! :) |
* bshoshany-thread-pool: add version 3.5.0 * Update recipes/bshoshany-thread-pool/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * bshoshany-thread-pool: compatibility w/ older releases --------- Co-authored-by: Uilian Ries <uilianries@gmail.com>
Specify library name and version: bshoshany-thread-pool/3.5.0