Fix pyqt error on macos-14 (macos-latest) #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in yml env files))
GenevieveBuckley
commented
May 8, 2024
constantinpape
approved these changes
May 8, 2024
constantinpape
merged commit d6c7422
into
computational-cell-analytics:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #558
Tests were failing on the macos-latest github runner (which currently runs the macos-14 M1 Mac image). The cause of this appears to be that pyqt was first being installed by conda/micromamba, then pip was uninstalling that and re-installing another pyqt. Something is wrong with the pyqt from pip, and it causes errors on M1 Mac machines.
Fix
The simplest solution is to remove
napari[all]from therequirements-dev.txtfile, so that pip does not try to uninstall the existing version of pyqt. All the github actions tests now finish without errors.