Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

332 handle non initialized image embeddings better in the plugins #498

Conversation

lufre1
Copy link
Contributor

@lufre1 lufre1 commented Apr 5, 2024

No description provided.

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor comments.

micro_sam/sam_annotator/_widgets.py Outdated Show resolved Hide resolved
micro_sam/sam_annotator/_widgets.py Show resolved Hide resolved
micro_sam/sam_annotator/_widgets.py Outdated Show resolved Hide resolved
micro_sam/sam_annotator/_widgets.py Outdated Show resolved Hide resolved
micro_sam/sam_annotator/_widgets.py Outdated Show resolved Hide resolved
micro_sam/sam_annotator/_widgets.py Outdated Show resolved Hide resolved
@lufre1
Copy link
Contributor Author

lufre1 commented Apr 5, 2024

Now, the handling of embeddings missing entirely should be added

@constantinpape
Copy link
Contributor

I had a quick look and this looks good from my end now. Let me know if you want to add anything else @lufre1, otherwise I will go ahead and merge it.

@lufre1
Copy link
Contributor Author

lufre1 commented Apr 8, 2024

I had a quick look and this looks good from my end now. Let me know if you want to add anything else @lufre1, otherwise I will go ahead and merge it.

@constantinpape
pushed some tiny changes, should be ready to merge from my side

@constantinpape
Copy link
Contributor

Thanks @lufre1 and looks good. I will merge it later after all tests have passed.

@constantinpape constantinpape merged commit d776498 into dev Apr 8, 2024
4 checks passed
@constantinpape constantinpape deleted the 332-handle-non-initialized-image-embeddings-better-in-the-plugins branch April 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants