Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare image signature of embeddings and current image #504

Open
constantinpape opened this issue Apr 8, 2024 · 0 comments
Open

Compare image signature of embeddings and current image #504

constantinpape opened this issue Apr 8, 2024 · 0 comments
Labels
discussion Do we want to add this feature adnd how? enhancement New feature or request

Comments

@constantinpape
Copy link
Contributor

We may want to compare the image signature for the current image and the embeddings when calling _validate_embeddings in order to make sure the user hasn't switched images without updating embeddings.

@lufre1 has implemented a version of this in #498, but I decided to deactivate this now because there were a few unclear cases and the overhead of computing the data signature every time segment or so is called would be quite large.

@constantinpape constantinpape added enhancement New feature or request discussion Do we want to add this feature adnd how? labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Do we want to add this feature adnd how? enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant