Perf. on /vulnerabilities endpoint.

computablefacts · Sep 12, 2024 · 09d07a3 · 09d07a3
1 parent effc09d
commit 09d07a3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php b/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php
@@ -104,13 +104,13 @@ public function getVulnerabilitiesWithAssetInfo(?int $attackerId = null): array
             ->join('scans', 'scans.id', '=', 'ports.scan_id')
             ->join('assets', 'assets.cur_scan_id', '=', 'scans.ports_scan_id')
             ->get()
-            ->filter(fn(Alert $alert) => !$attackerId || $alert->events($attackerId)->exists())
+            ->filter(fn(Alert $alert) => !$attackerId || !$alert->cve_id || $alert->events($attackerId)->exists())
             ->map(function (Alert $alert) use ($attackerId) {
                 return [
                     'alert' => $alert,
                     'asset' => $alert->asset(),
                     'port' => $alert->port(),
-                    'events' => $alert->events($attackerId)->get()->toArray(),
+                    'events' => $alert->cve_id ? $alert->events($attackerId)->get()->toArray() : [],
                 ];
             })
             ->toArray();