Update MauticInstaller to allow plugins & themes #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y names Update MauticInstaller to allow plugins & themes with custom directory names - Please do not merge yet
|
Tests added - please re-review. Thanks! |
niksamokhvalov
approved these changes
Apr 26, 2021
|
https://github.com/composer/installers/pull/484/checks?check_run_id=2435477260 These checks is failing. Fix it, please. |
|
Fixed the failing tests, was only not able to reproduce the PHP 5.3 test locally but I think I fixed it due to PHP 7 array syntaxes. Tests still work and phpstan is now also happy |
niksamokhvalov
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MauticInstaller to allow plugins & themes with custom directory names - this has been verified (composer create-project mautic/recommended-project:4.x-dev mauticcomposerproject --no-interaction) and can be committed!
I know the suggestion is to use installer-name, but there was a composer library https://github.com/mautic/composer-plugin that already had the convention of install-directory-name so I wanted to keep compatibility with that.