Add installer for TastyIgniter extensions and themes #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niksamokhvalov here's the new PR :) |
niksamokhvalov
requested changes
Feb 2, 2021
README.md
Outdated
| @@ -115,6 +115,7 @@ is not needed to install packages with these frameworks: | |||
| | Sylius | `sylius-theme` | |||
| | symfony1 | **`symfony1-plugin`** | |||
| | TAO | `tao-extension` | |||
| | TastyIgniter | **`igniter-extension`<br>`igniter-theme`** | |||
There was a problem hiding this comment.
I think, that we should use the full name for types to avoid confusion: tastyigniter-extension and tastyigniter-theme. Just as it is in CodeIgniter. Can you fix it? Also need to rename IgniterInstaller and IgniterInstallerTest classes.
niksamokhvalov
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.