Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuzz result] invalid entity with HTML5 prefix gets partially consumed #278

Closed
notriddle opened this issue Jan 27, 2024 · 0 comments · Fixed by #279
Closed

[fuzz result] invalid entity with HTML5 prefix gets partially consumed #278

notriddle opened this issue Jan 27, 2024 · 0 comments · Fixed by #279

Comments

@notriddle
Copy link
Contributor

This string matches the entity regex, and starts with an HTML5 legacy entity (&para, without a semicolon at the end):

&parag;

The reference implementations cmark and commonmark.js disagree on whether this is plain text (renders to the HTML &parag;) or if it starts with an entity (renders to the HTML ¶g;).

markdown-it agrees with commonmark.js, but commonmark-hs and pulldown-cmark agree with cmark.

I filed the bug here, because it seems to me cmark is right and commonmark.js is wrong.
notriddle added a commit to notriddle/commonmark.js that referenced this issue Jan 27, 2024
@notriddle
Do not process &-entities that don't end in ;
580bc1f 
Fixes commonmark#278
@notriddle notriddle mentioned this issue Jan 27, 2024
Merged
@jgm jgm closed this as completed in #279 Jan 28, 2024
jgm pushed a commit that referenced this issue Jan 28, 2024
@notriddle @jgm
Do not process &-entities that don't end in ;
0f94755 
Fixes #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not process &-entities that don't end in ; notriddle/commonmark.js
1 participant
@notriddle