-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commit): add '--allow-empty' flag to commit command #1217
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1217 +/- ##
==========================================
+ Coverage 97.33% 97.61% +0.27%
==========================================
Files 42 55 +13
Lines 2104 2519 +415
==========================================
+ Hits 2048 2459 +411
- Misses 56 60 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi, thanks for contributing! would like to know why do we want |
Coverage fixed 👍. Lee-W, apart from regular usage, it's because the staging area checks fail : $ cz c --allow-empty
-Invalid commitizen arguments were found: `--allow-empty`. Please use -- separator for extra git args
$ cz c -- --allow-empty
-No files added to staging!
# =======================
$ pipx uninstall commitizen; pipx install .
uninstalled commitizen! ✨ 🌟 ✨
installed package commitizen 3.29.0, installed using Python 3.12.3
These apps are now globally available
- cz
- git-cz
done! ✨ 🌟 ✨
# =======================
$ cz c --allow-empty
? Select the type of change you are committing feat: A new feature. Correlates with MINOR in SemVer
? What is the scope of this change? (class or file name): (press [enter] to skip)
test
? Write a short and imperative summary of the code changes: (lower case and no period)
test
? Provide additional contextual information about the code changes: (press [enter] to skip)
? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer No
? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip)
feat(test): test
[master 6b9618c5] feat(test): test
+Commit successful! |
If 'always_signoff' is enabled in configurations, or '-s' is used alone on the CLI, the following errors arise due to 'git commit' argument failures : > signoff mechanic is deprecated, please use `cz commit -- -s` instead. > fatal: /tmp/...: '/tmp/... is outside repository at '...' Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
…nd sources Details: The git sources folder ownership may be detected as dubious if running in a container with sources mounted to work on fixes and tests, breaking 'test_find_git_project_root' and 'test_get_commits_with_signature' > commitizen.exceptions.GitCommandError: fatal: detected dubious ownership in repository at '...' --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
As discussed, I redid it all into Tested locally with |
Description
feat(commit): add '--allow-empty' flag to commit command
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
Allow to invoke cz and create a commit without any change in it
Steps to Test This Pull Request
Additional context