feat(commit): implement questions 'filter' support with handlers #1207
+286
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianDC
force-pushed
the
questions-filter
branch
from
c120cae
to
5a661cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 97.33% 97.63% +0.29%
==========================================
Files 42 55 +13
Lines 2104 2534 +430
==========================================
+ Hits 2048 2474 +426
- Misses 56 60 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
AdrianDC
force-pushed
the
questions-filter
branch
3 times, most recently
from
e04ce53
to
5011a91
Compare
|
AdrianDC
force-pushed
the
questions-filter
branch
2 times, most recently
from
780b16b
to
c24db8a
Compare
Lee-W
requested changes
Aug 22, 2024
Lee-W
requested changes
Aug 22, 2024
Signed-off-by: Adrian DC <radian.dc@gmail.com>
> commitizen.exceptions.InvalidConfigurationError: Failed to parse not_exist.yaml: while scanning a double-quoted scalar > found unknown escape character 's' Signed-off-by: Adrian DC <radian.dc@gmail.com>
> test_commit_parser[config2] - AssertionError:
> assert '(?P<message>.*)' == '^(?P<change_...<message>.*)?'
> test_changelog_pattern[config2] - AssertionError:
> assert '.*' == '^(feature|bug fix)?(!)?'
> test_change_type_map[config2] - AssertionError:
> assert None == {'bug fix': 'Fix', 'feature': 'Feat'}
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Example: ./scripts/test -k 'test_commit_when_' --no-cov --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Details: If using a TOML configuration, the type was 'tomlkit.items.AoT' --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
…nd sources
Details: The git sources folder ownership may be detected as dubious if running
in a container with sources mounted to work on fixes and tests,
breaking 'test_find_git_project_root' and 'test_get_commits_with_signature'
> commitizen.exceptions.GitCommandError: fatal: detected dubious ownership in repository at '...'
---
Signed-off-by: Adrian DC <radian.dc@gmail.com>
AdrianDC
force-pushed
the
questions-filter
branch
from
c24db8a
to
d4d089e
Compare
AdrianDC
force-pushed
the
questions-filter
branch
from
d4d089e
to
968a900
Compare
AdrianDC
changed the title
AdrianDC
force-pushed
the
questions-filter
branch
from
968a900
to
65f4d93
Compare
Supported APIs:
- multiple_line_breaker
- required_validator
- required_validator_scope
- required_validator_subject_strip
- required_validator_title_strip
Example YAML configurations:
---
commitizen:
name: cz_customize
customize:
questions:
- ...
- type: input
name: scope
message: 'Scope of the change :'
filter: 'required_validator_scope'
default: ''
- type: input
name: subject
message: 'Title of the commit (starting in lower case and without period) :'
filter: 'required_validator_subject_strip'
default: ''
- type: input
name: body
message: 'Additional contextual message (Empty to skip) :'
default: 'Issue: #...'
filter: 'multiple_line_breaker'
---
Signed-off-by: Adrian DC <radian.dc@gmail.com>
AdrianDC
force-pushed
the
questions-filter
branch
from
65f4d93
to
314f3bf
Compare
|
Refactored as discussed : Supported APIs:
Example YAML configurations: commitizen:
name: cz_customize
customize:
questions:
- ...
- type: input
name: scope
message: 'Scope of the change :'
filter: 'required_validator_scope'
default: ''
- type: input
name: subject
message: 'Title of the commit (starting in lower case and without period) :'
filter: 'required_validator_subject_strip'
default: ''
- type: input
name: body
message: 'Additional contextual message (Empty to skip) :'
default: 'Issue: #...'
filter: 'multiple_line_breaker' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supported APIs: Common Python, commitizen.cz.utils.* functions
Example YAML configurations:
Additional commits to add missing YAML tests, fix YAML configurations, and then add the keys for this feature.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Example provided in the description
Additional context