mypy improvement #1054
Open
mypy improvement #1054
+26
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 97.33% 97.57% +0.23%
==========================================
Files 42 55 +13
Lines 2104 2518 +414
==========================================
+ Hits 2048 2457 +409
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lee-W
force-pushed
the
mypy-improvement
branch
from
1eb5aab
to
06eef86
Compare
17 tasks
woile
reviewed
Aug 22, 2024
| def example(self) -> str | None: | ||
| return self.custom_settings.get("example") | ||
| def example(self) -> str: | ||
| return self.custom_settings.get("example") or "" |
There was a problem hiding this comment.
You can set the default for the .get, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #1053, which intends to catch errors earlier through a more strict mypy setting.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context
#1053