-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove version tracker component #3620
Conversation
🦋 Changeset detectedLatest commit: 4698266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -37,7 +37,7 @@ Build the application bundles | |||
$ pnpm build | |||
|
|||
# or | |||
$ pnpm build:bundles:watch | |||
$ pnpm build:watch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to the rest of the changes, but build:bundles:watch
did not exist in the package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a changeset for a release.
@@ -181,7 +181,6 @@ export const MC_API_PROXY_TARGETS = { | |||
MACHINE_LEARNING: 'ml', | |||
PIM_SEARCH: 'pim-search', | |||
ORDER_SEARCH: 'order-search', | |||
MC_METRICS: 'mc-metrics', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: slightly unrelated change. If we'd be strict, then this was a breaking change. Did a quick search across all codebases and it doesn't seem to be used. So I think being pragmatic is fair.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'm fine with a minor/patch version as this is considered more of an internal usage.
sorry forgot about that, should it be a |
Yes. That minor is fine. |
@emmenko it seems the failing VRT is a usual suspect (flaky test) and actually the new output is the right one. |
commit with changeset: 4698266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks Levent 👏
Summary
As part of decommissioning mc-metrics service we are removing version tracker component which was using that service
Jira ticket