chore: update deps 💣 #1324
chore: update deps 💣 #1324
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/merchant-center-application-kit/2mp9tbd7i |
| @@ -121,7 +121,7 @@ describe('rendering', () => { | |||
| ]); | |||
| }); | |||
| it('should not render regex info', async () => { | |||
| await waitForElementToBeRemoved(() => rendered.getByText('Loading...')); | |||
| await waitForElementToBeRemoved(() => rendered.queryByText('Loading...')); | |||
There was a problem hiding this comment.
Detected by new eslint rule.
packages/application-shell/src/components/application-shell/application-shell.tsx
Outdated
Show resolved
Hide resolved
tdeekens
added
🙏 Status: Dev Review
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
5bb7490
to
b679050
Compare
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
b679050
to
c4a75c1
Compare
tsconfig.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "esModuleInterop": true, | |||
| "importHelpers": true, | |||
| // See https://devblogs.microsoft.com/typescript/typescript-and-babel-7/ | |||
| "isolatedModules": true, | |||
| "isolatedModules": false, | |||
There was a problem hiding this comment.
Fails if we set this to true. I've read a bit about it but not 100% sure. Did it fail in earlier versions of babel v7 when being true?
There was a problem hiding this comment.
Hmm as far as I know, if we use Babel we need to activate this flag. Did you find a reference or docs that say otherwise?
Also, I'm not sure how this change relates to any of the updated dependencies. What was the error that you got? 🤔
There was a problem hiding this comment.
I've also not found much otherwise. However, also confusing that it works. Typechecking jest however fails without.
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm wondering if we still need the @types/jest.
In any case, we need to keep isolatedModules: true and try to downgrade one of the packages so that we don't get the problem with the chalk dependency
There was a problem hiding this comment.
Yes, read that chalk issue too. It's a bit of a cat and mouse game. I now:
- Downgraded ts-jest
- Removed @types/jest (comes with jest itself)
This should work. However, it's a general issue: if any library uses language TS features babel can't compile we're doomed. This is the case somehow with the updated dependency of calk in ts-jest.
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
093693e
to
d4eb26a
Compare
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
d4eb26a
to
00b3410
Compare
|
@emmenko this should be good now as discussed. Had to rebase. The last 1-2 commits are relevant. |
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
00b3410
to
2c2c834
Compare
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
2c2c834
to
544d71c
Compare
This reverts commit 997e3d5.
tdeekens
force-pushed
the
td-chore-update-deps-2
branch
from
544d71c
to
bba024c
Compare
|
I presume the 👍 up was an approval. I will proceede to isolate some other dep updates where possible. |
Summary
Initially I set out to update flopflip and my weekends work. Then I noticed how much is outdated and spend a good amount of minutes to update things one by one.