Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"important" logging level #33302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

"important" logging level #33302

wants to merge 2 commits into from

Conversation

Quantizr
Copy link
Contributor

Adds the "important" logging level for events which need to be in qlogs but aren't errors.
Currently this list is:

  • controlsd.initialized
  • fingerprinted (forwarded INFO event from carlogger with extra={"important": True} attribute)

Not sure if swaglog.h and logger.h in various submodules should all be updated with the following defines (currently not)

#define CLOUDLOG_WARNING 30
#define CLOUDLOG_IMPORTANT 35
#define CLOUDLOG_ERROR 40
...

#define LOGW(fmt, ...) cloudlog(CLOUDLOG_WARNING, fmt, ## __VA_ARGS__)
#define LOGI(fmt, ...) cloudlog(CLOUDLOG_IMPORTANT, fmt, ## __VA_ARGS__)
#define LOGE(fmt, ...) cloudlog(CLOUDLOG_ERROR, fmt, ## __VA_ARGS__)
...
#define LOGW_100(fmt, ...) cloudlog_rl(2, 100, CLOUDLOG_WARNING, fmt, ## __VA_ARGS__)
#define LOGI_100(fmt, ...) cloudlog_rl(2, 100, CLOUDLOG_IMPORTANT, fmt, ## __VA_ARGS__)
#define LOGE_100(fmt, ...) cloudlog_rl(2, 100, CLOUDLOG_ERROR, fmt, ## __VA_ARGS__)

@sshane
Copy link
Contributor

sshane commented Aug 14, 2024

We have more important logs that aren't necessarily errors, check: fw_versions.py, vin.py. Are these handled?

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Aug 25, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants