camerad: fix event check in poll loop to validate POLLPRI #33255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* todo * nope * not this one * yep * passes * clean up * not used! * oop * update refs
improve signal view
…ommaai#32892) * fix services bug * add nonzero decimation assert
Update Python packages and pre-commit hooks Co-authored-by: Vehicle Researcher <user@comma.ai>
* add PR comment with screenshots on ui changes * fix pr comment if statements * use default shallow checkout * use commaai's ci-artifacts * use my ci-artifacts * use tj-actions/changed-files * clean up * use comma repos * make ci-artifacts branch openpilot/pr-# * remove redundent path
* push new docs * drop the new, just docs * cleanup
…ars (commaai#32932) Export fingerprints
Update Python packages and pre-commit hooks Co-authored-by: Vehicle Researcher <user@comma.ai>
only on master
* Increase traversal_limit_in_words to Fix Traversal Limit Errors * just use log_from_bytes * come on pycharm * no free lunch --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
…2936) Export fingerprints
* Chrysler Pacifica: combine 2017 and 2018 hybrids torque params are not accurate for either (might be ~1.5 for both checking a few dongles) * remove duplicate fingerprints * combine docs lines fix
bug fixes and improvements
fingerprint added
Add Corolla Sedan 2024 (South America), new 'engine' and 'eps' fwversion
* working * cache * bring back
* ssh docs * strict * need an index * push to prod
* update ci weekly report summary * don't add skipped jobs to report * uncomment job condition * use jinja template * add run number to failure links * add run number to failure links * Log for run #<num> * use list --------- Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
* bfg * filter repo is the new shit * down to 27M * move big files to lfs; remove external and phonelibs * wip - rebase devel; don't delete external and phonelibs anymore * wip - rebase devel hacks * wip - rebase devel updates * wip - rebase updates; lfs updates * cleaned unused scripts * wip - lfs fixes * bfg with rebase with correct dates * bfg script with cherry-pick method * latest git-filter-repo analysis * latest git-filter-repo 'before' analysis * new lfs import * latest git-filter-repo analysis * lfs update; renamed rebase repos * renamed scripts * different tmp folders for rewrite scripts; lfs update * gitattributes after lfs import * tag-commit-map file with old tags pointing to old commits * new tags * final touches * squash setup commits; cherry-pick validation; reverted to commaai remote * removed rebase version * 0.9.7 tag in tag-commit-map * removed unused openpilot-release-archive * fixed archive of old history because of 2 GB limit * archive of old history push master first * fix tags being deleted * cleaning and more logs * rewrite other branches with master history * Former-commit-id * updates to previous commits * cleanup --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
* rm make_can_msg * fix
* content of can packet won't affect can fingerprint time * remove get_one_can * fix comment * actually we still want to be able to send empty can (xx fingerprint func does this if it runs out of msgs) * fix process replay
* start * hmm API doesn't seem great * better * rm line * sendcan -> can_send callable for best static type coverage, list -> tuple msg TODO: logcan * more sendcan -> can_send references * remove pandad's capnp from selfdrive/car * fix and remove cereal from test_can_fingerprint * test_fw_fingerprint: remove pandad, less cereal * comment done too * better comment * fix test_models test * niceeee it works * move to can_definitions * can't come up with a better name :( * I think we can remove SimpleNamespace soon * fix test_can_fingerprint.py * maintain previous behavior * Revert "maintain previous behavior" This reverts commit f848fd3. * can test comment * no need for get_one_can now! * big clean up: no SimpleNamespace * now self explanatory! * not needed * use empty can again since this is now real * cmt
move getenv check to global
* i love zsh * check
* add rules * allow failure on docker
Co-authored-by: Comma Device <device@comma.ai>
…3244) fix dynamic lib linking on mac
round to even
* move capnp byte decoding out of car_helpers * always wanted to type this * and process replay * this does nothing * might as well
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
adeebshihadeh
force-pushed
the
master
branch
from
29af572
to
0058ea5
Compare
|
This PR was closed because of a git history rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the event handling in the poll loop to specifically check for the
POLLPRIevent.Previously, the code used
if (!fds[0].revents) continue;to skip iterations when no events were detected. However, this didn’t specifically check for the POLLPRI event.Even when POLLPRI is specified in the events field, the revents field can still include flags like POLLERR or POLLHUP, etc. after poll returns. These flags indicate different events or errors on the file descriptor, independent of the specific event being polled for. So, it’s important to specifically check for POLLPRI in the revents field.
The updated condition ensures that the code only continues when
POLLPRIis correctly detected, preventing unintended event processing.