Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: Add Lexus GS F 2016 #30245

Merged
merged 32 commits into from
Nov 14, 2023
Merged

Toyota: Add Lexus GS F 2016 #30245

merged 32 commits into from
Nov 14, 2023

Conversation

calvinchui382025
Copy link
Contributor

@calvinchui382025 calvinchui382025 commented Oct 14, 2023

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: ab9b64a5e5960cba|2023-10-17--18-59-12
  • route with stock system: ab9b64a5e5960cba|2023-10-14--00-38-19

@github-actions github-actions bot added the car vehicle-specific label Oct 14, 2023
@calvinchui382025
Copy link
Contributor Author

Stuck with a "CAN Error: Check Connections". Been messing around but not sure what else I can do.

@calvinchui382025
Copy link
Contributor Author

It's working properly with the Lexus GSF now. Mine is a 2016, it will likely work with the 2017.

Most likely won't work with the 2018-2020's since they have a different ACC system.

@calvinchui382025
Copy link
Contributor Author

I'm not sure if I did the first step correctly (running selfdrive/car/docs.py bugs out on my computer).

Can someone verify?

@sshane
Copy link
Contributor

sshane commented Oct 17, 2023

Thanks for the port! Can you provide a new route for the tests? That one seems to be missing all the logs. Once you do, I can request upload, then you just keep the device on WiFi.

@sshane
Copy link
Contributor

sshane commented Oct 21, 2023

Any update on the route? Any issues you noticed with the car and openpilot so far?

@calvinchui382025
Copy link
Contributor Author

calvinchui382025 commented Oct 21, 2023

Any update on the route? Any issues you noticed with the car and openpilot so far?

Hi Shane, sorry I have been out of town for a funeral but I get back tonight.

No issues so far, working as expected

@calvinchui382025
Copy link
Contributor Author

Any update on the route? Any issues you noticed with the car and openpilot so far?

ab9b64a5e5960cba|2023-10-17--18-59-12 I uploaded all the files within Connect and I made the route public in useradmin

Copy link

@gaurovgiri gaurovgiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sshane
Copy link
Contributor

sshane commented Oct 24, 2023

If you end up getting a new test route, let me know. Looks like encoderd crashed there any didn't capture any qcams. Not a dealbreaker if you can't get a new one though, just a nice to have to view the videos while exploring the routes

@sshane
Copy link
Contributor

sshane commented Oct 25, 2023

@calvinchui382025
Copy link
Contributor Author

Can I use https://connect.comma.ai/ab9b64a5e5960cba/1698186728072/1698187358620 ?

Yes that's fine, I made it public in useradmin. I'll upload the Connect files tomorrow

@gsf2016
Copy link

gsf2016 commented Oct 29, 2023

i would like to try this on my 2016 GS F. i have a comma 3. what url should i use to load into my comma 3? thanks!

@calvinchui382025
Copy link
Contributor Author

i would like to try this on my 2016 GS F. i have a comma 3. what url should i use to load into my comma 3? thanks!

Try this

https://smiskol.com/fork/snyperifle
or
https://smiskol.com/fork/snyperifle/master

We may need to add your car's computer fingerprints but see if that works

@gsf2016
Copy link

gsf2016 commented Nov 1, 2023

https://smiskol.com/fork/snyperifle/master looks to be working for me. Plugged it in and made it all the way to the calibration step. Will go out for a drive later this week, Really excited to try this out on the GS F!

@gsf2016
Copy link

gsf2016 commented Nov 1, 2023

Just came back from a quick drive. Happy to report it works perfect!!

@sshane sshane changed the title Toyota: Add Lexus GSF 2016 Toyota: Add Lexus GS F 2016 Nov 14, 2023
@sshane sshane merged commit 2647a4b into commaai:master Nov 14, 2023
21 of 22 checks passed
scott0129 pushed a commit to scott0129/openpilot-1 that referenced this pull request Nov 17, 2023
* added GSF ECU values

* Added Lexus GSF data

* added route for GSF

* test RC code

* revert fingerprints back from RC test to GSF

* fixed type for route

* specify route segment for GSF

* added GSF to torque substitute

* removed year designation for GSF

* added MY back to all "Lexus GSF"

* removed route, don't think it does anything

* move GSF ecu values to better place

* remove whitespace from toyota > interface.py

* added in public route for LEXUS_GSF

* added GSF to docs

* update test route

* update test route

* update 266 Supported cars

* trying different dbc

* updated to working route

* clean up

* add to releases

* updated test route

* new route

* docs

* slightly better torque params

---------

Co-authored-by: cchui <cchui@eogresources.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
scott0129 pushed a commit to scott0129/openpilot-1 that referenced this pull request Nov 17, 2023
* added GSF ECU values

* Added Lexus GSF data

* added route for GSF

* test RC code

* revert fingerprints back from RC test to GSF

* fixed type for route

* specify route segment for GSF

* added GSF to torque substitute

* removed year designation for GSF

* added MY back to all "Lexus GSF"

* removed route, don't think it does anything

* move GSF ecu values to better place

* remove whitespace from toyota > interface.py

* added in public route for LEXUS_GSF

* added GSF to docs

* update test route

* update test route

* update 266 Supported cars

* trying different dbc

* updated to working route

* clean up

* add to releases

* updated test route

* new route

* docs

* slightly better torque params

---------

Co-authored-by: cchui <cchui@eogresources.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants