-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: Add Lexus GS F 2016 #30245
Toyota: Add Lexus GS F 2016 #30245
Conversation
Stuck with a "CAN Error: Check Connections". Been messing around but not sure what else I can do. |
trying different dbc
It's working properly with the Lexus GSF now. Mine is a 2016, it will likely work with the 2017. Most likely won't work with the 2018-2020's since they have a different ACC system. |
I'm not sure if I did the first step correctly (running selfdrive/car/docs.py bugs out on my computer). Can someone verify? |
Thanks for the port! Can you provide a new route for the tests? That one seems to be missing all the logs. Once you do, I can request upload, then you just keep the device on WiFi. |
Any update on the route? Any issues you noticed with the car and openpilot so far? |
Hi Shane, sorry I have been out of town for a funeral but I get back tonight. No issues so far, working as expected |
ab9b64a5e5960cba|2023-10-17--18-59-12 I uploaded all the files within Connect and I made the route public in useradmin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
If you end up getting a new test route, let me know. Looks like encoderd crashed there any didn't capture any qcams. Not a dealbreaker if you can't get a new one though, just a nice to have to view the videos while exploring the routes |
Yes that's fine, I made it public in useradmin. I'll upload the Connect files tomorrow |
i would like to try this on my 2016 GS F. i have a comma 3. what url should i use to load into my comma 3? thanks! |
Try this https://smiskol.com/fork/snyperifle We may need to add your car's computer fingerprints but see if that works |
https://smiskol.com/fork/snyperifle/master looks to be working for me. Plugged it in and made it all the way to the calibration step. Will go out for a drive later this week, Really excited to try this out on the GS F! |
Just came back from a quick drive. Happy to report it works perfect!! |
* added GSF ECU values * Added Lexus GSF data * added route for GSF * test RC code * revert fingerprints back from RC test to GSF * fixed type for route * specify route segment for GSF * added GSF to torque substitute * removed year designation for GSF * added MY back to all "Lexus GSF" * removed route, don't think it does anything * move GSF ecu values to better place * remove whitespace from toyota > interface.py * added in public route for LEXUS_GSF * added GSF to docs * update test route * update test route * update 266 Supported cars * trying different dbc * updated to working route * clean up * add to releases * updated test route * new route * docs * slightly better torque params --------- Co-authored-by: cchui <cchui@eogresources.com> Co-authored-by: Shane Smiskol <shane@smiskol.com>
* added GSF ECU values * Added Lexus GSF data * added route for GSF * test RC code * revert fingerprints back from RC test to GSF * fixed type for route * specify route segment for GSF * added GSF to torque substitute * removed year designation for GSF * added MY back to all "Lexus GSF" * removed route, don't think it does anything * move GSF ecu values to better place * remove whitespace from toyota > interface.py * added in public route for LEXUS_GSF * added GSF to docs * update test route * update test route * update 266 Supported cars * trying different dbc * updated to working route * clean up * add to releases * updated test route * new route * docs * slightly better torque params --------- Co-authored-by: cchui <cchui@eogresources.com> Co-authored-by: Shane Smiskol <shane@smiskol.com>
Checklist
selfdrive/car/docs.py
to generate new docs