Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ENG-283 Nav update #638

Draft
wants to merge 101 commits into
base: master
Choose a base branch
from
Draft

feat: ENG-283 Nav update #638

wants to merge 101 commits into from

Commits on Apr 9, 2024

  1. Rename styles for less confusion with other nav

    @AndyEPhipps
    AndyEPhipps committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d8ca04a View commit details
    Browse the repository at this point in the history

  2. Remove functionality & styles re: cloning menu items

    @AndyEPhipps
    AndyEPhipps committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    14c171e View commit details
    Browse the repository at this point in the history

  3. Tidy-up

    @AndyEPhipps
    AndyEPhipps committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    08dda45 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Lol I've done it all wrong

    @AndyEPhipps
    AndyEPhipps committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f02de1e View commit details
    Browse the repository at this point in the history

  2. Use pre-existing data

    @AndyEPhipps
    AndyEPhipps committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e433979 View commit details
    Browse the repository at this point in the history

  3. Start updating styles

    @AndyEPhipps
    AndyEPhipps committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    dfd7f4a View commit details
    Browse the repository at this point in the history

  4. More hover styles

    @AndyEPhipps
    AndyEPhipps committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0663cf3 View commit details
    Browse the repository at this point in the history

  5. Breakpoint-dependent rendering of icons n buttons

    @AndyEPhipps
    AndyEPhipps committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    53c9be1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. CSS3 animations

    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    de7a3fe View commit details
    Browse the repository at this point in the history

  2. Icon animations

    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ae12782 View commit details
    Browse the repository at this point in the history

  3. Target Header icons only

    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c18969a View commit details
    Browse the repository at this point in the history

  4. Ditch keyframes for lighter transitions

    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    dc769c5 View commit details
    Browse the repository at this point in the history

  5. Start on mobile specific styles

    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    852fce1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of https://github.com/comicrelief/component-lib… 

    …rary into ENG-2834_nav_update
    @AndyEPhipps
    AndyEPhipps committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0ed89c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Fix rel property

    @AndyEPhipps
    AndyEPhipps committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7ff10dc View commit details
    Browse the repository at this point in the history

  2. Clarify naming

    @AndyEPhipps
    AndyEPhipps committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3b24e7f View commit details
    Browse the repository at this point in the history

  3. Add in cloned menu item for mobile only

    @AndyEPhipps
    AndyEPhipps committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c582e19 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Prototype limit logic

    @AndyEPhipps
    AndyEPhipps committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    41bfc6c View commit details
    Browse the repository at this point in the history

  2. Target logic

    @AndyEPhipps
    AndyEPhipps committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9e896c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Unpicking logic nightmare

    @AndyEPhipps
    AndyEPhipps committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1cf645b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Fix mobile nav

    @AndyEPhipps
    AndyEPhipps committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    32fe731 View commit details
    Browse the repository at this point in the history

  2. Tidyup, bring in new markup logic

    @AndyEPhipps
    AndyEPhipps committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f94873f View commit details
    Browse the repository at this point in the history

  3. Prototyping

    @AndyEPhipps
    AndyEPhipps committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9423c07 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Sussed out nightmare nesting

    @AndyEPhipps
    AndyEPhipps committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    29000e0 View commit details
    Browse the repository at this point in the history

  2. Broken everything

    @AndyEPhipps
    AndyEPhipps committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b25eb61 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'master' of https://github.com/comicrelief/component-lib… 

    …rary into ENG-2834_nav_update
    @AndyEPhipps
    AndyEPhipps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    29ad618 View commit details
    Browse the repository at this point in the history

  2. Debug

    @AndyEPhipps
    AndyEPhipps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    fdb9bc7 View commit details
    Browse the repository at this point in the history

  3. Step back, but reintroduce new stuff to troubleshoot

    @AndyEPhipps
    AndyEPhipps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a004e44 View commit details
    Browse the repository at this point in the history

  4. Fix render logic

    @AndyEPhipps
    AndyEPhipps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    dd8d9d2 View commit details
    Browse the repository at this point in the history

  5. Towel throw-in for today:

    @AndyEPhipps
    AndyEPhipps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5f426d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Process nav BEFORE render to circumnavigate state issues

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3ce1f99 View commit details
    Browse the repository at this point in the history

  2. Remove some now-necessary markup

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1333ea2 View commit details
    Browse the repository at this point in the history

  3. Reupdate nonmobile nav re:firstchild

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5412098 View commit details
    Browse the repository at this point in the history

  4. Comment through the nonsense

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6ff9239 View commit details
    Browse the repository at this point in the history

  5. Rename gibberish function

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ac21ee1 View commit details
    Browse the repository at this point in the history

  6. Tighten up keyevents

    @AndyEPhipps
    AndyEPhipps committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    afc6e59 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fix import

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    480d26c View commit details
    Browse the repository at this point in the history

  2. Clearer naming, clone and extending components

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    75415b2 View commit details
    Browse the repository at this point in the history

  3. Tidyup

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    13f154f View commit details
    Browse the repository at this point in the history

  4. Fix More item markup

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b2a1b0a View commit details
    Browse the repository at this point in the history

  5. Remove unncessary styles

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1a27839 View commit details
    Browse the repository at this point in the history

  6. Tidyup old markup

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a791312 View commit details
    Browse the repository at this point in the history

  7. Handle endless mess of styles

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a0544c5 View commit details
    Browse the repository at this point in the history

  8. Hover events

    @AndyEPhipps
    AndyEPhipps committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cada661 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'master' of https://github.com/comicrelief/component-lib… 

    …rary into ENG-2834_nav_update
    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    965923c View commit details
    Browse the repository at this point in the history

  2. Fix imports

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fd38d7e View commit details
    Browse the repository at this point in the history

  3. Trigger logo animation in correct place

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6b82180 View commit details
    Browse the repository at this point in the history

  4. Animations

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    49dc9c2 View commit details
    Browse the repository at this point in the history

  5. Tidying

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8852a58 View commit details
    Browse the repository at this point in the history

  6. Update snaps

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    750dc4f View commit details
    Browse the repository at this point in the history

  7. Test fix 1

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6c12550 View commit details
    Browse the repository at this point in the history

  8. More useful data attributes

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    164b404 View commit details
    Browse the repository at this point in the history

  9. New data-attributes for tests

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8fff74e View commit details
    Browse the repository at this point in the history

  10. Improve icon data-attributes

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8430ba0 View commit details
    Browse the repository at this point in the history

  11. Test fix 2

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c15e3f9 View commit details
    Browse the repository at this point in the history

  12. Fix shop selector with new markup

    @AndyEPhipps
    AndyEPhipps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f0c83e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Test stuff

    @AndyEPhipps
    AndyEPhipps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cb74dab View commit details
    Browse the repository at this point in the history

  2. Better tests

    @AndyEPhipps
    AndyEPhipps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    66e810e View commit details
    Browse the repository at this point in the history

  3. Update snaps

    @AndyEPhipps
    AndyEPhipps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    10e1b35 View commit details
    Browse the repository at this point in the history

  4. Mobile styles

    @AndyEPhipps
    AndyEPhipps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f728263 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Yet more styling

    @AndyEPhipps
    AndyEPhipps committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e1b31c4 View commit details
    Browse the repository at this point in the history

  2. Fix WYMD carousel imgs

    @AndyEPhipps
    AndyEPhipps committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    31759b1 View commit details
    Browse the repository at this point in the history

  3. Attempt to start resize stuff

    @AndyEPhipps
    AndyEPhipps committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    88e4811 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Midway thru animating opacity

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    15a2ee5 View commit details
    Browse the repository at this point in the history

  2. Fix More dropdown

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1c71d96 View commit details
    Browse the repository at this point in the history

  3. Fix mobile nav

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cd397b5 View commit details
    Browse the repository at this point in the history

  4. Finesse animations

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    910171c View commit details
    Browse the repository at this point in the history

  5. Improve animation, sort out revealtext widths

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8a1b85e View commit details
    Browse the repository at this point in the history

  6. Revealtext tweak

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    de05490 View commit details
    Browse the repository at this point in the history

  7. Less full-on cR logo rotate

    @AndyEPhipps
    AndyEPhipps committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    934e19a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Set-up header donate button animation

    @AndyEPhipps
    AndyEPhipps committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7a9b3de View commit details
    Browse the repository at this point in the history

  2. Bottom donate button too.

    @AndyEPhipps
    AndyEPhipps committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ad11da1 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Handle keyboard focus issue

    @AndyEPhipps
    AndyEPhipps committed May 9, 2024
    Configuration menu
    Copy the full SHA
    55d76e1 View commit details
    Browse the repository at this point in the history

  2. Tidyup

    @AndyEPhipps
    AndyEPhipps committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1ffdbe4 View commit details
    Browse the repository at this point in the history

  3. Animation tweka

    @AndyEPhipps
    AndyEPhipps committed May 9, 2024
    Configuration menu
    Copy the full SHA
    29728e9 View commit details
    Browse the repository at this point in the history

  4. Still tryign to improve animations 🤷

    @AndyEPhipps
    AndyEPhipps committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6feef0e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. cge branch 'master' of https://github.com/comicrelief/comicrelief-con… 

    …tentful into ENG-2840_map

Merge branch 'master' of https://github.com/comicrelief/component-library into ENG-2834_nav_update
    @AndyEPhipps
    AndyEPhipps committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9cc2d4b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Fix RevealText bug

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c714210 View commit details
    Browse the repository at this point in the history

  2. BG colour inherit

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1368092 View commit details
    Browse the repository at this point in the history

  3. Bg colour inheritance

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e4484f2 View commit details
    Browse the repository at this point in the history

  4. Space fix

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8e593e0 View commit details
    Browse the repository at this point in the history

  5. Change of plan

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1d7e617 View commit details
    Browse the repository at this point in the history

  6. Tweak Nav breakpoint to suit new design & functionality

    @AndyEPhipps
    AndyEPhipps committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    73d9599 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Snap update

    @AndyEPhipps
    AndyEPhipps committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    22241cf View commit details
    Browse the repository at this point in the history

  2. Post-chat tweaks

    @AndyEPhipps
    AndyEPhipps committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fe7324d View commit details
    Browse the repository at this point in the history

  3. Tweak nav breakpoint to fit

    @AndyEPhipps
    AndyEPhipps committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0df457b View commit details
    Browse the repository at this point in the history

  4. Snaps

    @AndyEPhipps
    AndyEPhipps committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ea53931 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Experimenting with nav scrolling

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f723975 View commit details
    Browse the repository at this point in the history

  2. Desktop fixes

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4afba05 View commit details
    Browse the repository at this point in the history

  3. Alt nav examples

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4c094f1 View commit details
    Browse the repository at this point in the history

  4. Fix duplicated IDs

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    337c676 View commit details
    Browse the repository at this point in the history

  5. Re-add bottom donate button now we can scroll

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f57f4a6 View commit details
    Browse the repository at this point in the history

  6. Remove scrolling for testing

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e038a91 View commit details
    Browse the repository at this point in the history

  7. Dropshadows

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    aeeefb8 View commit details
    Browse the repository at this point in the history

  8. Fix subsubmenu shadow bug

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    66ae171 View commit details
    Browse the repository at this point in the history

  9. Fix breakpoint changes

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0529a86 View commit details
    Browse the repository at this point in the history

  10. Tidyup

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    82a0958 View commit details
    Browse the repository at this point in the history

  11. Chevron updates

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    35774bb View commit details
    Browse the repository at this point in the history

  12. Tweakz

    @AndyEPhipps
    AndyEPhipps committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    05c2c43 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Tweak More chevrons

    @AndyEPhipps
    AndyEPhipps committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3f44dce View commit details
    Browse the repository at this point in the history

  2. Beef up CL style overrides

    @AndyEPhipps
    AndyEPhipps committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c9bd4cb View commit details
    Browse the repository at this point in the history