feat: SingleMsgDS focal point updates #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
This will place a
object-fitposition CSS rule on an SingleMessageDS image when supplied with the following details via the new CMS fields:Why is this required?
Request from Design/Content; the current styles will just centre the image, and depending on the image and breakpoint, it can sometimes look a bit crap; this gives us the ability to better position the image on a case-by-case basis.
link to Jira ticket:
https://comicrelief.atlassian.net/browse/ENG-1737