-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved flush to after_call #354
Conversation
This look good to me, thanks :) Let's wait for @japdubengsub to review and approve before we merge @dsblank Do you think we should update the docs ? Could be good to add a paragraph in the log_traces page |
d8e0889
to
a210760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I wasn't part of the initial discussion on this task since I joined the project a bit later, so I might be slightly out of context.
Everything looks okay!
My only concern is that this might negatively impact batching mode. However, since both this mode and batching are disabled by default, there shouldn't be any significant issues. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests?
a210760
to
fb56267
Compare
@andrescrz, I can't find a test of |
fb56267
to
71ccdb2
Compare
71ccdb2
to
dff22c4
Compare
As discussed offline, this was tested manually prior to merge, so it's fine to go from my end. We can add a test if any issue or at a later stage. |
Details
This PR adds @track(flush=True) so that you don't have to do it manually after the function has been called.
Before:
After:
Issues
None, except for adding some convenience.
Testing
No tests added.
Documentation
Docstring for flush added.