Upgrade to XGBoost 1.7.3 and serialize objective for XGBoostClassificationModel #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeichenXu123
approved these changes
Feb 23, 2023
The objective param is not saved / loaded correctly. |
harupy
commented
Feb 23, 2023
| @@ -17,7 +17,7 @@ object Dependencies { | |||
| lazy val slf4jVersion = "1.7.36" | |||
| lazy val awsSdkVersion = "1.11.1033" | |||
| val tensorflowJavaVersion = "0.4.0" // Match Tensorflow 2.7.0 https://github.com/tensorflow/java/#tensorflow-version-support | |||
| val xgboostVersion = "1.6.1" | |||
| val xgboostVersion = "1.7.3" | |||
There was a problem hiding this comment.
Let's see what happens with the latest version
|
CC @jsleight |
harupy
force-pushed
the
serialize-objective
branch
from
53bfbc7
to
8c69ae0
Compare
harupy
force-pushed
the
serialize-objective
branch
from
d9f6df6
to
2213073
Compare
WeichenXu123
approved these changes
Feb 23, 2023
WeichenXu123
approved these changes
Feb 24, 2023
jsleight
approved these changes
Feb 24, 2023
jsleight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve
objectivewhen serializingXGBoostClassificationModel.objectiveis used intransform:https://github.com/dmlc/xgboost/blob/a65ad0bd9c26ff0ce4cb842d3312064cd1e9eadc/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala#L396