-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up post-0.11.x old docsites into Antora #3325
Conversation
This is because these need to be updated before we tag the next release. I always did that when tagging a Mill release. But as you suggested, we can also open a |
Took me a while to recognize that this change is only visible via |
@lefou I updated the PR to also replace the versions in |
btw do you know if there's some way to speedup/cache/parallelize the antora build step? With the addition of graphviz and the duplication due to an old version, generated the pages now takes really long |
Not yet. Part of the slowdowns is probably because we clean the directory every time. I don't use Antora elsewhere, so I have no idea what build times to expect in general. A quick search discovered, that there is a Gradle plugin for Antora, which is used by the spring project to render their documentation. We could look how they do it, maybe port it over. |
Fixes #2455
They can now be added to
val docTags
, and will appear as previous versions on the docsiteTo support this mostly transparently, I checkout the relevant versions of com-lihaoyi/mill as part of
githubPages
and run./mill
to build their docs. This saves us the hassle of storing the materialized.adoc
files somewhere and worrying about them getting stale/corrupted/accessible/etc.The versions listed in
docs/antora.yml
are incorrect for some of the old tags like 0.11.10. We probably should generate them inbuild.sc
to avoid duplication.If we intend to support ongoing development of old branches, we probably should use moving
0.11.x
branches rather than fixed0.11.x
tags for the doc-site, so that improvements to the documentation would get picked up without additional releases. We might also want to make the latest stable version the default page, so we can merge incremental documentation intomain
without confusing users. But these improvements can come in follow ups