Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate input tasks in inspect command #3102

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 27, 2024

Before, inspect may show multiple instances of the same input task:

> mill inspect main.docJar
...
main.docJar(ScalaModule.scala:332)
    The documentation jar, containing all the Javadoc/Scaladoc HTML files, for
    publishing to Maven Central

Inputs:
    main.compileClasspath
    main.scalaVersion
    main.scalaOrganization
    main.scalaDocClasspath
    main.scalacPluginClasspath
    main.scalaDocOptions
    main.scalaVersion
    main.scalaVersion
    main.docResources
    main.docSources
    main.scalaVersion
    main.docResources
    main.docSources
    main.docSources

After, it's only showing each input once:

> mill inspect main.docJar
...
main.docJar(ScalaModule.scala:332)
    The documentation jar, containing all the Javadoc/Scaladoc HTML files, for
    publishing to Maven Central

Inputs:
    main.compileClasspath
    main.scalaVersion
    main.scalaOrganization
    main.scalaDocClasspath
    main.scalacPluginClasspath
    main.scalaDocOptions
    main.docResources
    main.docSources

Please note, inspect isn't incorrect when showing multiple entries of the same input. Due to the generic implementation, tasks can depend on the same input multiple times. But since inspect does provide information to the user, it' not beneficial to list all raw dependencies.

@lefou lefou changed the title Deduplicate input tasks in inspect command Deduplicate input tasks in inspect command Mar 27, 2024
@lefou
Copy link
Member Author

lefou commented Mar 27, 2024

This fixes a regression of #1558

@lefou lefou merged commit 13a31e5 into main Mar 27, 2024
38 checks passed
@lefou lefou deleted the inspect-dedup-inputs branch March 27, 2024 14:12
@lefou lefou added this to the 0.11.8 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants