Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala to 2.13.12 #2759

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Update Scala to 2.13.12 #2759

merged 5 commits into from
Sep 19, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 19, 2023

No description provided.

@lefou lefou changed the base branch from main to post-release September 19, 2023 06:24
Base automatically changed from post-release to main September 19, 2023 07:20
build.sc Outdated Show resolved Hide resolved
@lefou
Copy link
Member Author

lefou commented Sep 19, 2023

Build fails with a strage error message:

 -------------------------------- Running Tests --------------------------------
[info] compiling 1 Scala source to /home/runner/work/mill/mill/out/integration/feature/scoverage/fork/workspaceDir.dest/out/mill-build/compile.dest/classes ...
[info] done compiling
1 targets failed
core[2.13.11].scoverageToolsClasspath 
Resolution failed for 1 modules:
--------------------------------------------
  org.scoverage:scalac-scoverage-plugin_2.13.12:2.0.10 
	not found: /home/runner/.ivy2/local/org.scoverage/scalac-scoverage-plugin_2.13.12/2.0.10/ivys/ivy.xml
	not found: https://repo1.maven.org/maven2/org/scoverage/scalac-scoverage-plugin_2.13.12/2.0.10/scalac-scoverage-plugin_2.13.12-2.0.10.pom

--------------------------------------------

For additional information on library dependencies, see the docs at
https://mill-build.com/mill/Library_Dependencies.html

X mill.integration.ScoverageTests.test 23340ms 
  utest.AssertionError: assert(eval("core[2.13.11].scoverage.xmlReport"))
    utest.asserts.Asserts$.assertImpl(Asserts.scala:30)
    mill.integration.ScoverageTests$.$anonfun$tests$2(ScoverageTests.scala:10)

Why strange? Because the project under test is configured to use Scala version 2.13.11 and Scoverage 2.0.10, but the error message indicates Scala version 2.13.12

@lefou
Copy link
Member Author

lefou commented Sep 19, 2023

Ah, scoverage reporting needs to run in the Mill classpath, hence it must be resolved with the Scala version used to run Mill.

@lefou lefou merged commit ad3b62a into main Sep 19, 2023
37 checks passed
@lefou lefou deleted the update-scala branch September 19, 2023 21:38
@lefou lefou added this to the 0.11.5 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant