Port parse tests #427
Port parse tests #427
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| name: "hsl()", | ||
| tests: [ | ||
| { | ||
| name: "hsl(), commas", |
There was a problem hiding this comment.
Does the output not show the parent name before the child name or in a way that implies containment?
There was a problem hiding this comment.
It does, the function portion of the name is redundant
| expect: '{"spaceId":"hsl","coords":[90,0,0],"alpha":0.5}' | ||
| }, | ||
| { | ||
| name: "hsla(), rad for hue, spaces and slash", |
There was a problem hiding this comment.
This (and some of the ones after) mention hsla() but use hsl(), is that what the original tests did?
There was a problem hiding this comment.
That's what the original tests did.
|
I'm going to leave the redundant/incorrect hsl functions in the test names for now. I don't think hsl is spec compliant so I'll open a new issue for that (#428). The tests can be corrected as part of dealing with that issue. |
Closes #393
Shoutout to Github Copilot!