Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for Next.js production build bug #421

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

lloydk
Copy link
Collaborator

@lloydk lloydk commented Feb 10, 2024

Workaround for a Next.js bug when generating a production build of a Next.js project.

Fixes #260

Workaround for a Next.js bug when generating a production build
of a Next.js project using Color.js.

See this Github issue for an analysis of the bug:
color-js#260
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit e7ed648
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/65c7ed3515310a00089e97fc
😎 Deploy Preview https://deploy-preview-421--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that points to the issue so that we don't inadvertently change it in the future?

@lloydk
Copy link
Collaborator Author

lloydk commented Feb 10, 2024

Can you add a comment that points to the issue so that we don't inadvertently change it in the future?

Done

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@LeaVerou LeaVerou merged commit 8b2d429 into color-js:main Feb 11, 2024
4 checks passed
@lloydk lloydk deleted the nextjs-bug branch March 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.display and .toString different behavior on nextjs in dev and build mode
4 participants