[types] Add missing overload for set
#419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MysteryBlokHed
force-pushed
the
types/add-set-overloads
branch
from
3d226de
to
024ce82
Compare
|
(Force pushed because of accidental formatting changes) |
jgerigmeyer
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setfunction can also take an object of coordinates to modify, as described in the README: https://github.com/color-js/color.js#manipulating-colorsThis PR changes the types to reflect this.
The reason that the definition on the
Colorclass had to be changed is because of how TypeScript handles overloaded functions in other types (i.e.ToColorPrototype). Without this, only the last signature of thesetfunction would be present onColor.