Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect parsing of Jzazbz percentage values #392

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

lloydk
Copy link
Collaborator

@lloydk lloydk commented Feb 3, 2024

The az and bz coordinates for the Jzazbz color space have negative reference range values so percentage values are being mapped incorrectly.

Before this PR
before

After this PR
after

The parsing tests haven't been converted to the new format so I added a test case to the old parsing tests.

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit e6ab02c
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/65beb402e9929a00084ba898
😎 Deploy Preview https://deploy-preview-392--colorjs.netlify.app/tests/parse
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Any chance you could open an issue for the parsing tests? Can't believe I missed that when converting!

@LeaVerou LeaVerou merged commit 49455aa into color-js:main Feb 3, 2024
4 checks passed
@lloydk lloydk deleted the jzazbz branch February 9, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants