Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaces] Add percentages to color functions #314

Merged
merged 2 commits into from
May 29, 2023

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented May 25, 2023

This adds percentage handling to:

  • lch
  • lab
  • oklch
  • oklab
  • lab-d65

It defines percentage ranges in the coords section.

This PR also adds tests to confirm that the percentage form works in these, as well as the predefined color spaces- no changes were needed for those.

… percentage handling on other supported spaces
@jamesnw jamesnw marked this pull request as ready for review May 25, 2023 16:55
Copy link
Member

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all looks good

@svgeesus svgeesus merged commit 1997013 into color-js:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants