Apply linting rules. #238
Merged
Apply linting rules. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
reviewed
Nov 4, 2022
| Here are a few other guidelines that cannot be enforced via ESLint: | ||
|
|
||
| - When you define a function, use a space between the opening paren and its name. That way we can search for "functionName (" and find its definition immediately, instead of having to wade through calls to the function. | ||
| - Prefer single-word names over multi-word names. 3+ word names are especially frowned upon. |
There was a problem hiding this comment.
@LeaVerou I removed this note because I added an ESLint rule to enforce this convention -- so I thought the note is no longer applicable. If you prefer, I'm happy to add it back.
There was a problem hiding this comment.
No need :) Thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the existing linting rules, and adds a few rules to match the
.editorconfigsettings.