Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust format type and add serialize type test. #237

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

jgerigmeyer
Copy link
Member

@jgerigmeyer jgerigmeyer commented Nov 4, 2022

This adds a type test for the change in d0ab5d1, and also adjusts the Format type to account for the change in 667c19a.

@LeaVerou
Copy link
Member

LeaVerou commented Nov 4, 2022

Thanks! LGTM, though I'm thinking of renaming noAlpha to opaque or opaqueOnly since negative names are an API design antipattern. Though "opaque" is a more obscure word, and that's also an antipattern. 🤔

@LeaVerou LeaVerou merged commit b2a75be into color-js:main Nov 4, 2022
@jgerigmeyer jgerigmeyer deleted the cleanup-types branch November 4, 2022 15:26
@jgerigmeyer
Copy link
Member Author

Thanks! LGTM, though I'm thinking of renaming noAlpha to opaque or opaqueOnly since negative names are an API design antipattern. Though "opaque" is a more obscure word, and that's also an antipattern. 🤔

Maybe includeAlpha and default to true?

@LeaVerou
Copy link
Member

LeaVerou commented Nov 4, 2022

Thanks! LGTM, though I'm thinking of renaming noAlpha to opaque or opaqueOnly since negative names are an API design antipattern. Though "opaque" is a more obscure word, and that's also an antipattern. 🤔

Maybe includeAlpha and default to true?

Booleans that default to true is another API Design antipattern, possibly a bigger one…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants