Fix missing import #210
Merged
Fix missing import #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing GET import OOOPS
Also don't need the get luminance import luminance.js as it's done in lab_d65
LeaVerou
approved these changes
Aug 26, 2022
|
Hi there, how did this work without the missing import? Did you not run it? |
Hi Lea, @LeaVerou I know I did run it as that is how I found the syntax error in commit 61c648b... But I didn't realize it was not calculating correctly till I ran the BLACK & WHITE page. Doh! Contributing factor is that my IDE may need to be set up a little differently when working with color.js. This won't happen again. Sorry!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing GET import OOOPS
When I aligned delptaPhi.js to the color.js patterns, I missed adding the appropriate import for get.js sorry!