[contrast / deltaPhi] #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New contrast module, deltaPhiStar 𝜟𝜱✴︎ https://github.com/Myndex/deltaphistar
|
Thank you! |
svgeesus
requested changes
Aug 21, 2022
src/contrast/deltaPhi.js
Outdated
| color1 = getColor(color1); | ||
| color2 = getColor(color2); | ||
|
|
||
| let Lstr1 = YtoLstar(Math.max(getLuminance(color1), 0)); |
There was a problem hiding this comment.
Suggest instead the simpler:
let Lstr1 = get(color1, [lab, "l"]);I see that negative luminance is clamped to zero; is there a particular risk of negative luminance?
There was a problem hiding this comment.
...is there a particular risk of negative luminance?
No, I was literally just following the pattern of the other contrast modules here. I started this module based on Weber.js, which had the same clamp. I am not familiar enough with the total color.js library to know what is an important pattern...
There was a problem hiding this comment.
fe321fa updates deltaPhi.js to ~match Lstar.js, except using lab-d65.js
Added a d65 version of lab, for use with DeltaPhiStar
fix import lab_d65
svgeesus
approved these changes
Aug 23, 2022
MysteryBlokHed
added a commit
to MysteryBlokHed/color.js
that referenced
this pull request
Nov 16, 2022
Updates the types to include changes that were missed in v0.4.1, specifically from PR's color-js#209 and color-js#219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New contrast module, deltaPhiStar 𝜟𝜱✴︎
https://github.com/Myndex/deltaphistar
This version is approximately aligned with APCA light mode.
deltaPhiStar 𝜟𝜱✴︎ is symmetric and does not consider polarity. It is intended as a general purpose perceptual contrast method, which is similar to APCA, and useable for high spatial frequency stimuli on self-illuminated monitors.
May be particularly useful for dataviz elements.