Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oklab() and oklch() do not accept plain numbers for lightness #225

Closed
LeaVerou opened this issue Oct 20, 2022 · 1 comment
Closed

oklab() and oklch() do not accept plain numbers for lightness #225

LeaVerou opened this issue Oct 20, 2022 · 1 comment
Labels
beginner friendly Tractable issues, good for first time contributors

Comments

@LeaVerou
Copy link
Member

Lines to be changed:

https://github.com/LeaVerou/color.js/blob/main/src/spaces/oklab.js#L71
https://github.com/LeaVerou/color.js/blob/main/src/spaces/oklch.js#L65

Lab and LCH are fine:

https://github.com/LeaVerou/color.js/blob/main/src/spaces/lab.js#L71
https://github.com/LeaVerou/color.js/blob/main/src/spaces/lch.js#L64
@LeaVerou LeaVerou added the beginner friendly Tractable issues, good for first time contributors label Oct 20, 2022
@LeaVerou LeaVerou changed the title oklab and oklch do not accept percentages for lightness oklab and oklch do not accept plain numbers for lightness Oct 20, 2022
@LeaVerou LeaVerou changed the title oklab and oklch do not accept plain numbers for lightness oklab() and oklch() do not accept plain numbers for lightness Oct 20, 2022
@svgeesus
Copy link
Member

Lab and LCH also need to be changed, as serialization of CIE Lightness is now to <number> as is serialization of OK Lightness

svgeesus added a commit that referenced this issue Oct 20, 2022
@svgeesus
[spaces] Lab,LCG,Oklab,Oklch lightness in number or percent. Seriliza…
3dfd3c5 
…tion in sumber. Fix #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly Tractable issues, good for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeaVerou @svgeesus