Remove gamut mapping from hsl, hwb and hsv (#331)

color-js · Oct 11, 2023 · 6a3535a · 6a3535a
1 parent f71745c
commit 6a3535a
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 9 deletions.
diff --git a/src/spaces/hsl.js b/src/spaces/hsl.js
@@ -68,7 +68,6 @@ export default new ColorSpace({
 
 	formats: {
 		"hsl": {
-			toGamut: true,
 			coords: ["<number> | <angle>", "<percentage>", "<percentage>"],
 		},
 		"hsla": {

diff --git a/src/spaces/hsv.js b/src/spaces/hsv.js
@@ -54,10 +54,5 @@ export default new ColorSpace({
 			(l === 0 || l === 1)? 0 : ((v - l) / Math.min(l, 1 - l)) * 100,
 			l * 100
 		];
-	},
-	formats: {
-		color: {
-			toGamut: true,
-		}
 	}
 });
diff --git a/src/spaces/hwb.js b/src/spaces/hwb.js
@@ -52,7 +52,6 @@ export default new ColorSpace({
 
 	formats: {
 		"hwb": {
-			toGamut: true,
 			coords: ["<number> | <angle>", "<percentage>", "<percentage>"],
 		}
 	}

diff --git a/tests/conversions.html b/tests/conversions.html
@@ -36,6 +36,7 @@
 let convertToOK = convertTo("oklab");
 let convertToOKLCh = convertTo("oklch");
 let convertTosrgbLin = convertTo("srgb-linear");
+let convertToHSV = convertTo("hsv");
 
 </script>
 
@@ -176,6 +177,39 @@ <h1>sRGB to HWB</h1>
 	</table>
 </section>
 
+<section>
+	<h1>Out of RGB gamut conversions</h1>
+	<table class="reftest" data-test="numbers" data-columns="3" data-colors="1">
+		<tr title="HWB">
+			<td>color(rec2020 0 0 1)</td>
+			<td>
+				<script>
+					convertToHWB();
+				</script>
+			</td>
+			<td>230.639, -29.921, -5.0489</td>
+		</tr>
+		<tr title="HSL">
+			<td>color(rec2020 0 0 1)</td>
+			<td>
+				<script>
+					convertToHSL();
+				</script>
+			</td>
+			<td>230.639, 179.655, 37.564</td>
+		</tr>
+		<tr title="HSV">
+			<td>color(rec2020 0 0 1)</td>
+			<td>
+				<script>
+					convertToHSV();
+				</script>
+			</td>
+			<td>230.639, 128.483, 105.0489</td>
+		</tr>
+	</table>
+</section>
+
 <section>
 	<h1>sRGB to HSL</h1>
 	<table class="reftest" data-test="numbers" data-columns="3" data-colors="1">

diff --git a/tests/parse.html b/tests/parse.html
@@ -351,8 +351,8 @@ <h1>hsl()</h1>
 			<td>{"spaceId":"hsl","coords":[NaN,0,0],"alpha":0.5}</td>
 		</tr>
 		<tr title="hsla(), oog color(rec2020 0 0 1)">
-			<td>hsl(90deg 0% 0% / .5)</td>
-			<td>{"spaceId":"hsl","coords":[90,0,0],"alpha":0.5}</td>
+			<td>hsl(230.6 179.7% 37.56% / 1)</td>
+			<td>{"spaceId":"hsl","coords":[230.6,179.7,37.56],"alpha":1}</td>
 		</tr>
 		<tr title="hsl(), none hue ">
 			<td>hsl(none, 50%, 50%)</td>