Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select block whenever it is clicked on navtree #84

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MAX-786
Copy link
Member

@MAX-786 MAX-786 commented Jun 29, 2024

Fixes #14

You can go to "Order" tab in sidebar and rearrange order of tabs which will reflect on frontend in realtime ( if subscribed on 'onEditChange' at frontend ). Also when you click on a block in navtree the border will move to that block and you can switch to "Block" tab to edit it.

2024-06-29.15-53-14.mp4

@MAX-786 MAX-786 requested a review from djay June 29, 2024 10:31
@djay
Copy link
Member

djay commented Jun 29, 2024

@MAX-786 I'm not sure but shouldn't click once switch tabs to the block tab also? Is the nav tree got any function to delete or add a block or maybe that is to be added under the block tab?

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 29, 2024

I'm not sure but shouldn't click once switch tabs to the block tab also?

IMO while trying it out myself, if i wanted to know the location of the block from the Order Tab in the frontend I can just click on it and see the border appear on a block. And delete it or drag it up and down. And if i want to edit its content i can click on Block Tab to do so, which i believe is just one click ahead .

Is the nav tree got any function to delete or add a block or maybe that is to be added under the block tab?

I did saw a delete button right next to Block's name in Order Tab, but for some reasons it is not showing here, lemme see what is breaking this. And currently navtree do not have add block button tho.

@djay
Copy link
Member

djay commented Jun 29, 2024

We can try it and see

@MAX-786
Copy link
Member Author

MAX-786 commented Jul 2, 2024

@djay Now, it changes tab to Block whenever it is clicked in Order tab, so do we want this? I can push code to remote if yes!
[Update] clicking a block in Order tab will now also scroll the block in iframe into viewport.

2024-07-02.19-43-30.mp4

@djay
Copy link
Member

djay commented Jul 3, 2024

@MAX-786 yes i think it's better this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can Click on block in blocks nav tree and edit it in sidebar , save and see it changed in preview
2 participants