See real time updates when you change title in sidebar #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de onEditChange to subscribe for changes
MAX-786
changed the title
|
Reference data parameter as same as ploneClient data. |
djay
requested changes
Jun 18, 2024
|
@MAX-786 Logic all looks fine (I didn't dive too deeply, but it all seems to work well!), I've left a few review comments to improve code readability. I'm happy to merge once those are all resolved |
JeffersonBledsoe
requested changes
Jun 19, 2024
|
Assuming the other PR resolves all the noted comments, looks good to me! |
for reference this one I was talking abt PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
2024-06-16.02-47-13.mp4