Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can Click on block in blocks nav tree and edit it in sidebar , save and see it changed in preview #14

Open
Tracked by #2
MAX-786 opened this issue May 23, 2024 · 7 comments · May be fixed by #84
Open
Tracked by #2

Comments

@MAX-786
Copy link
Member

MAX-786 commented May 23, 2024

No description provided.

@djay
Copy link
Member

djay commented Jun 5, 2024

as discussed. take victors navtree code and include it in this addon to just get a very basic list of blocks. Later we can take this out and use the proper navtree that will be included in 18.

@djay
Copy link
Member

djay commented Jun 6, 2024

@MAX-786 this is his latest version. We probably can't wait to have this merged but we can just copy some of the code and make a simpler version for now that list lists out the blocks

plone/volto#5642

@djay djay changed the title I can Click on block in blocks nav tree and edit it in sidebar I can Click on block in blocks nav tree and edit it in sidebar , save and see it changed in preview Jun 10, 2024
@djay
Copy link
Member

djay commented Jun 12, 2024

@JeffersonBledsoe it seems like the blocks nav branch is almost finished. Would there be any problem using it as is and therefore using the latest 18 and 6.1 backend?

@djay
Copy link
Member

djay commented Jun 12, 2024

Descision was to wait until the navtree is released into a 18 alpha and instead do the click on preview to select earlier #24

@djay
Copy link
Member

djay commented Jun 19, 2024

Not something that needs to be solved here but seems that blocks navtree doesn't really have a good logical place in the quanta design.

Tabs are gone and instead you get a settings button

Image

and if you close the sidebar then you would have to use the quanta toolbar to open it again

Image

One obvious option is another icon in the toolbar. But its going to take up space for something not that often used.

Instead I think it should be both in the Page settings and in the block settings

  • in the page settings as a section
    • this means you can still select a block even with block clicking disabled
  • in the block settings as a breadcrumb up the top above the block name, with a dropdown/expand icon.
    • this expands into block navigation
    • this means that you also get a quick way to go up to the parent and some information about containment

@djay
Copy link
Member

djay commented Jun 27, 2024

@MAX-786 the order tab is now deployed but I can't see to click on a block and edit it. I'm not sure if thats something you've broken or thats just not meant to be how it works?

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 27, 2024

@MAX-786 the order tab is now deployed but I can't see to click on a block and edit it. I'm not sure if thats something you've broken or thats just not meant to be how it works?

In volto, clicking on blocks in Order tab will select the block on screen, so I am aiming for that for the iframe. I'll create a seperate PR for that.

@MAX-786 MAX-786 linked a pull request Jun 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants